Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename new shard-manager service to shard-distributor #6496

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Nov 14, 2024

What changed?
Renamed the new shard-manager service to shard-distributor

Why?
We want to split the shard management system in two service, shard-distributor and a load-balancer. Also there is already a shard manager struct in the code, which would be quite confusing

How did you test it?
Unit tests

Potential risks
The change is NOT backwards compatible, the service is still prototyping so noone show rely on it. We need to change the names internally when we pull in this change.

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (a6c36bf) to head (e385981).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
common/service/metrics.go 0.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
common/service/name.go 100.00% <ø> (ø)
service/sharddistributor/service.go 94.23% <100.00%> (ø)
common/service/metrics.go 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c36bf...e385981. Read the comment docs.

@jakobht jakobht merged commit b97e553 into cadence-workflow:master Nov 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants