Update root partition to refresh non-root partition on start #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| c.stopWG.Add(1) | ||
| go func() { | ||
| defer c.stopWG.Done() | ||
| c.notifyPartitionConfig(context.Background(), *c.partitionConfig, int(c.partitionConfig.NumReadPartitions)) |
There was a problem hiding this comment.
nit: we should add a ctx and cancelFn pair to tasklist manager to better respond to shutdown events and avoid using background context for this kind of background stuff
taylanisikdemir
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update root partition to refresh non-root partition on start
Why?
If root partition is stopped while it's trying to send notifications about an update to non-root partitions, some partitions may not receive the notification. In this case, update root partition to send notification on start so that they can receive the notification.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes