Create naive isolation group matching loadbalancer #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| taskListType: taskListType, | ||
| } | ||
| wI := lb.weightCache.Get(taskListKey) | ||
| if wI == nil { | ||
| return lb.fallbackLoadBalancer.PickReadPartition(domainID, taskList, taskListType, forwardedFrom) | ||
| return lb.fallbackLoadBalancer.PickReadPartition(taskListType, req, isolationGroup) |
There was a problem hiding this comment.
multiLoadBalancer has the common checks and must be the only one used directly as wrapper going forward. It also has a defaultLoadBalancer. So we may simplify weightedLoadBalancer by getting rid of fallback logic and returning a special error to indicate fallback to default lb is needed.
There was a problem hiding this comment.
Agreed. Going to address in followup refactor.
| } | ||
|
|
||
| func (i *isolationLoadBalancer) pickBetween(partitions map[int]any) int { | ||
| // Could alternatively use backlog weights to make a smarter choice |
There was a problem hiding this comment.
yes! this would be great enhancement
There was a problem hiding this comment.
Discussed offline, will add in followup.
taylanisikdemir
approved these changes
Dec 19, 2024
This is an intentionally naive implementation of a load balancer that assigns isolation groups to specific partitions and routes pollers/tasks to those partitions based on their isolation group. Any time there are multiple options one is picked randomly. The goal of this implementation is to benchmark how significantly isolation-group-based routing improves task latencies and isolation group containment for non-extremely-skewed scenarios. It additionally provides a baseline to see how much a more sophisticated solution (storing the isolation group assignment with the partitions and dynamically rebalancing them) might improve these metrics. This isn't intended to be used in production as-is.
Shaddoll
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intentionally naive implementation of a load balancer that assigns isolation groups to specific partitions and routes pollers/tasks to those partitions based on their isolation group. Any time there are multiple options one is picked randomly.
The goal of this implementation is to benchmark how significantly isolation-group-based routing improves task latencies and isolation group containment for non-extremely-skewed scenarios. It additionally provides a baseline to see how much a more sophisticated solution (storing the isolation group assignment with the partitions and dynamically rebalancing them) might improve these metrics.
This isn't intended to be used in production as-is.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes