Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cassandra queries for tables #6614

Merged

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Jan 11, 2025

What changed?
Update Cassandra queries for tables:

Table_Name created_time last_updated_time
executions In previous PR In previous PR
history_node Done no need
history_tree Done no need
tasks Done Done
domains Done no
domains_by_name_v2 Done Yes (But it is type bigint)
queue Done no
queue_metadata Done Done
cluster_config No Has timestamp

Note: Cluster_config table has a col called timestamp. And it only has INSERT operation called by a update_cluster_config function. I assume it uses insert as both create and update: this means created_time can’t be added.

Why?
Can debug more conveniently

How did you test it?
Unit test
Manually tested in mono repo:
history_node
Screenshot 2025-01-13 at 4 03 21 PM

historytree
Screenshot 2025-01-13 at 4 04 28 PM

tasks
Screenshot 2025-01-15 at 2 30 56 PM

domains
Screenshot 2025-01-15 at 2 27 03 PM

domains_by_name_v2
Screenshot 2025-01-15 at 2 29 19 PM

queue
Screenshot 2025-01-15 at 2 32 36 PM

queue_metadata
Screenshot 2025-01-15 at 2 54 38 PM
Empty since this one doesn't insert/update too often

Potential risks

Release notes

Documentation Changes

@bowenxia bowenxia enabled auto-merge (squash) January 16, 2025 19:14
@bowenxia bowenxia merged commit 8b5e2a5 into master Jan 16, 2025
22 of 23 checks passed
@bowenxia bowenxia deleted the xbowen/update_cassandra_query_with_timestamps/other_tables branch January 16, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants