Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instanciate shard distributor client #6620

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented Jan 15, 2025

What changed?
Instanciate the shard distributor client with the correct outbonds, and make it available from the clientBean.

Why?
We need to instanciate the client so we can use it to look up things with the shard distributor

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a nit, but overall, it should be OK to merge/continue iterating on this.

common/resource/resource_impl.go Outdated Show resolved Hide resolved
@jakobht jakobht force-pushed the instanciate-shard-distributor-client branch from 62b9d10 to a03eeee Compare January 15, 2025 10:40
@jakobht jakobht merged commit be54846 into cadence-workflow:master Jan 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants