Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate all model parameters from discretization parameters in input file #176

Closed
jbreue16 opened this issue Mar 11, 2024 · 0 comments · Fixed by #177
Closed

Separate all model parameters from discretization parameters in input file #176

jbreue16 opened this issue Mar 11, 2024 · 0 comments · Fixed by #177
Labels

Comments

@jbreue16
Copy link
Contributor

jbreue16 commented Mar 11, 2024

We have some model parameters that are specified in the discretization subgroup, namely NBOUND, NPARTYPEand PAR_GEOM. They should be moved up by one level, i.e. into the unit_XXX group to achieve a separation of model and discretization parameters, making the interface more consistent/clear.
This should not be a breaking change, i.e. we should read from the old location if the new one does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant