clean model configuration #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sleweke @schmoelder you think this is good to be squashed and merged? |
schmoelder
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
This PR addresses some long standing inconsistencies in the interface while also ensuring backwards compatibility. For future modifications, we should instead refer to the CADET-Specification repo (still WIP) and make sure to update the spec to the currently supported spec version of CADET-Core.
jbreue16
force-pushed
the
chore/clean_model_config
branch
from
9d6a3e9 to
2ba7fa7
Compare
Some model parameters were written in the discretization group and are moved to the model group. Backwards compatibility of the interface is ensured. See #177 Move NBOUND from discretization to unit_XXX Move NPARTYPE from discretization to unit_XXX Move PAR_GEOM from discretization to unit_XXX
jbreue16
force-pushed
the
chore/clean_model_config
branch
from
2ba7fa7 to
c8317a7
Compare
jbreue16
added a commit
that referenced
this pull request
Apr 2, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177)
jbreue16
added a commit
that referenced
this pull request
Apr 17, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177)
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
May 5, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 8, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
May 23, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 28, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 31, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
Jun 3, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should separate all model parameters from discretization parameters in the input file (fixes #176 ).
This should not be a breaking change so we have to make sure that the old interface is read when the new one is not present.
Move NBOUND from discretization to unit_XXX
Move NPARTYPE from discretization to unit_XXX
Move PAR_GEOM from discretization to unit_XXX