Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CAPI #283

Open
5 tasks
jbreue16 opened this issue Sep 2, 2024 · 0 comments
Open
5 tasks

Improve CAPI #283

jbreue16 opened this issue Sep 2, 2024 · 0 comments
Milestone

Comments

@jbreue16
Copy link
Contributor

jbreue16 commented Sep 2, 2024

Open ends from #115 as documented by @schmoelder :

TODO

  • On unit operation level, WRITE_SOLUTION_LAST_UNIT could be renamed to WRITE_SOLUTION_LAST. I don't think anyone is using this feature yet so a breaking change is justifiable in my opinion.
  • WRITE_SOLDOT_LAST(_UNIT) is completely missing; at least in the documentation. Check if it works.
  • Same for WRITE_SENS_LAST(_UNIT) and WRITE_SENSDOT_LAST(_UNIT).
  • (Maybe) Rename LAST_STATE_SENSY_XXX => LAST_STATE_SENS_XXX, and LAST_STATE_SENSYDOT_XXX => LAST_STATE_SENSDOT_XXX (breaking change in output might break some stuff)
  • Currently, the order of dimensional arguments in the API is different from the order of the dimensions in the state vector. If possible, we should fix this to make it more consistent. I can foresee stupid implementation errors in the future... 🙈
@jbreue16 jbreue16 added this to the v6.0.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant