-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing CAPI methods #115
Conversation
ad2bdaa
to
f88e04c
Compare
We implemented most of the methods but still need to test them (which we will do in tomorrow's Dev-Call). The reason why the test suite fails is probably because of the following: https://github.com/modsim/CADET/blob/master/test/testCAPIv1.cpp#L3 So we need to modify the tests to make them OS independent. |
405a3cf
to
5b99a23
Compare
6009067
to
5c977ae
Compare
5c977ae
to
950299f
Compare
950299f
to
906dffe
Compare
5f20306
to
036d7bb
Compare
cf51499
to
1883e4a
Compare
1883e4a
to
e5770b5
Compare
40682b4
to
e8c0cf7
Compare
22447a7
to
c0fc3d8
Compare
The file format is hardcoded in both the driver.hpp where the meta output is written and now also hardcoded (with value 040000) for the CAPI. |
5f8bfab
to
4d8ce95
Compare
4d8ce95
to
67a9226
Compare
67a9226
to
959d0f2
Compare
I don't understand the build issue with MacOS. If you have time, could you please have a look @sleweke? |
This PR is ready to be reviewed! 🥳 We test all unit operations using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MacOS build has been fixed, and all tests have successfully passed. Dimensionality of outputs has been thoroughly tested by @schmoelder.
All necessary changes for v5 have been implemented. Any outstanding issues are documented in #283.
* Add various missing CAPI methods * Add write last sensitivity state for units * Do not write out particle dimension for LRMP * Add method to return CAPI version number * Update documentation Co-authored-by: Johannes Schmoelder <[email protected]> Co-authored-by: Jan Breuer <[email protected]>
cc46464
to
acec1e6
Compare
* Add various missing CAPI methods * Add write last sensitivity state for units * Do not write out particle dimension for LRMP * Add method to return CAPI version number * Update documentation Co-authored-by: Johannes Schmoelder <[email protected]> Co-authored-by: Jan Breuer <[email protected]>
acec1e6
to
cd625c8
Compare
* Add various missing CAPI methods * Add write last sensitivity state for units * Do not write out particle dimension for LRMP * Add method to return CAPI version number * Update documentation Co-authored-by: Johannes Schmoelder <[email protected]> Co-authored-by: Jan Breuer <[email protected]>
cd625c8
to
d4e2b31
Compare
Since PR #59 was closed prematurely, this is a continuation.
Original description:
Adds a simple C interface to libcadet. The parameter provider interface
is realized by callback functions. A simulation can be performed and
the solution at the outlet of the unit operations can be queried.
Also includes a test application that dynamically loads the library at
runtime (only Windows) and executes a simulation specified in JSON
format internally.
This commit provides the first steps regarding #16 and, thus, #12.
To do:
/meta/time_sim
)/meta/file_format
Moreover, some things are still unclear / inconsitent and will be addressed later, see #283