-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add h5 to testrunner and use static libraries in debug mode #172
Conversation
Alright, with this Pipeline we at least know, that the problem isn't in the CmakeSettings.json. |
dda9c49
to
191b402
Compare
@ronald-jaepel Do we want to keep the static linking in debug mode? |
Here's a blog post about static vs dynamic. It contains everything I know about the subject. :D AFAIK the main drawback of static links is:
I think both of those are non-issues for us, so I'd vote for keeping it statically linked. It solves all of those "Can't find x.dll" errors. Edit: found another drawback:
|
I agree to trade this potential drawback at buildtime for resolving the "Can't find x.dll" issues. |
I don't know enough about dynamically/statically linked libraries, and even less so for Windows, so take my opinion with a grain of salt.
I don't see any issue here
So be it. We're just talking about debug mode here, right? |
Yes, just the debug mode. The release build is statically linked anyways and has afaik always been. |
Alright, lets merge this then. |
To expand our tests (as proposed in #167 ), we want to use the standard CADET setup files in .h5 format for our reference solutions.
To read from h5 files in our tests, we include the h5 lib in the testrunner target.
We additionally link to static libraries to ease the use of debug builds.