Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exchange module for the MCT #257

Merged
merged 17 commits into from
Nov 20, 2024
Merged

Conversation

AntoniaBerger
Copy link
Collaborator

@AntoniaBerger AntoniaBerger commented Jul 31, 2024

Fixes #252

Work structure:

  • Create a new exchange modul. #256
  • Add exchange as a part of the MCT modul
    • make exchange parameter parameter part of MCT
    • ubdate parameter handler for phaseTransitionModel
    • Test results
  • Outsourse Iteration and declaration for residual and Jacobian?

Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of minor remarks that need to be addressed before merging.

I thought about adding a dummy Exchange (similar to what we have for binding), but decided against it since there should always be some exchange in the MCT, as using that model doesnt make sense without.

Tests still work, so I'll approve this PR to be merged after minor revision.
It would still be interesting if the abstraction layer has any influence on the performance of the MCT. A benchmark would be nice, comparing the old and new implementation wrt computational performance.

@AntoniaBerger AntoniaBerger force-pushed the feature/exchange_modul_MCT branch from f224479 to 052cbaf Compare October 18, 2024 07:48
@jbreue16 jbreue16 force-pushed the feature/exchange_modul_MCT branch from 8e3312a to f89eb6f Compare November 20, 2024 12:32
Copy link
Contributor

@schmoelder schmoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntoniaBerger for your first major contribution to CADET-Core. Before merging, please add documentation and interface specifications. Also, please try to clean up the commit history a bit.

@jbreue16
Copy link
Contributor

jbreue16 commented Nov 20, 2024

Before merging, please add documentation and interface specifications.

Modeling and interface has not changed, this PR only changes the infrastructure in preparation of the changes in #271 , which will have implications on modeling and interface

Also, please try to clean up the commit history a bit.

I think we can just squash and merge all of this into one commit, or do you knwo some logical chunks, which all run and work, we can separate this into @AntoniaBerger ?

@AntoniaBerger
Copy link
Collaborator Author

AntoniaBerger commented Nov 20, 2024

Not sure, but I think one commit will be enough.

@schmoelder
Copy link
Contributor

Thanks for the clarification.

@AntoniaBerger AntoniaBerger merged commit f9e963a into master Nov 20, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@AntoniaBerger AntoniaBerger deleted the feature/exchange_modul_MCT branch November 20, 2024 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add an exchange module for the MCT
3 participants