-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an exchange module for the MCT #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple of minor remarks that need to be addressed before merging.
I thought about adding a dummy Exchange (similar to what we have for binding), but decided against it since there should always be some exchange in the MCT, as using that model doesnt make sense without.
Tests still work, so I'll approve this PR to be merged after minor revision.
It would still be interesting if the abstraction layer has any influence on the performance of the MCT. A benchmark would be nice, comparing the old and new implementation wrt computational performance.
src/libcadet/model/parts/MultiChannelConvectionDispersionOperator.cpp
Outdated
Show resolved
Hide resolved
src/libcadet/model/parts/MultiChannelConvectionDispersionOperator.hpp
Outdated
Show resolved
Hide resolved
src/libcadet/model/parts/MultiChannelConvectionDispersionOperator.hpp
Outdated
Show resolved
Hide resolved
f224479
to
052cbaf
Compare
Resolves #256
Without template configurations
8e3312a
to
f89eb6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AntoniaBerger for your first major contribution to CADET-Core. Before merging, please add documentation and interface specifications. Also, please try to clean up the commit history a bit.
Modeling and interface has not changed, this PR only changes the infrastructure in preparation of the changes in #271 , which will have implications on modeling and interface
I think we can just squash and merge all of this into one commit, or do you knwo some logical chunks, which all run and work, we can separate this into @AntoniaBerger ? |
Not sure, but I think one commit will be enough. |
Thanks for the clarification. |
Fixes #252
Work structure: