Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(accessors): update get/set methods to allow for arrays to be traversed #45

Merged
merged 2 commits into from
May 26, 2019

Conversation

cahilfoley
Copy link
Owner

BREAKING CHANGE: The get and set methods will new process numeric path accessors as array indicies. This is probably the expected behaviour but wasn't how it previously worked and is therefore a breaking change.

…aversed

BREAKING CHANGE: The get and set methods will new process numeric path accessors as array indicies. This is probably the expected behaviour but wasn't how it previously worked and is therefore a breaking change.
@coveralls
Copy link

coveralls commented May 26, 2019

Pull Request Test Coverage Report for Build 460

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 100.0%

Totals Coverage Status
Change from base Build 457: 1.0%
Covered Lines: 170
Relevant Lines: 170

💛 - Coveralls

@cahilfoley cahilfoley merged commit 9207675 into master May 26, 2019
@cahilfoley cahilfoley deleted the feature/accessor-array-paths branch May 26, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants