*: Add first version of the code #1
Conversation
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
caicloud-bot
added
do-not-merge/release-note-label-needed
cmd/kubeflow-kernel/main.go
Outdated
| // TODO: Using a real s2i client. | ||
| s2iClient := s2i.New() | ||
|
|
||
| interpreter := interpreter.New() |
There was a problem hiding this comment.
nit: do not shadow package name, ditto for manager and kernel.
pkg/manager/manager.go
Outdated
| } | ||
| } | ||
|
|
||
| func (m Manager) Execute(code string) (*types.Job, error) { |
pkg/interpreter/simple/simple.go
Outdated
| } | ||
| } | ||
|
|
||
| func (i Interpreter) Preprocess(code string) (*types.Parameter, error) { |
There was a problem hiding this comment.
ditto, add godoc for public methods
artifacts/kernel.json
Outdated
| "kubeflow-kernel", | ||
| "{connection_file}" | ||
| ], | ||
| "display_name": "Kubeflow", |
There was a problem hiding this comment.
I think we will support Python 2 & 3 in the future, while now we can set to Kubeflow-Python3
artifacts/kernel.json
Outdated
| "{connection_file}" | ||
| ], | ||
| "display_name": "Kubeflow", | ||
| "language": "Python" |
There was a problem hiding this comment.
Python3 vs Python2? we probably need to make clear (even though the pr doesn't implement python integration)
|
For these suggestions about improvements, I have opened some issues to keep track. And I will address other comments today or tomorrow. |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
|
@ddysher Addressed, PTAL |
|
Thanks! btw, can u add /lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ddysher Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
First PR without OWNERS file, manually merge. |
/assign @ddysher