Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool resolution for multiple names should be breadth first #2743

Closed
gitfool opened this issue Mar 23, 2020 · 1 comment · Fixed by #2744
Closed

Tool resolution for multiple names should be breadth first #2743

gitfool opened this issue Mar 23, 2020 · 1 comment · Fixed by #2744
Milestone

Comments

@gitfool
Copy link
Contributor

gitfool commented Mar 23, 2020

Following up from cake-contrib/Cake.DotNetTool.Module#20, I discovered the unexpected and inconsistent behavior that a tool with one name in the PATH was preferred over the tool with another name in the tool registry or tools directory.

Specifically, in this case, GitVersion.exe is already installed into the PATH by Chocolatey for the Windows virtual environment used by GitHub Actions. During the Cake build, a different version is specified to be installed into the Cake tools subdirectory; it should have been used instead but was not, since the current tool resolution strategy does not take into account multiple tool executable names for each tool resolution source, and so is effectively depth first.

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants