Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch GRM to not mark GitHub release as a pre-release #2814

Closed
gep13 opened this issue Jun 26, 2020 · 2 comments
Closed

Switch GRM to not mark GitHub release as a pre-release #2814

gep13 opened this issue Jun 26, 2020 · 2 comments
Assignees
@gep13
Labels
Build
Milestone
v1.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jun 26, 2020

This was discussed within the Team Slack, and a decision was made to change this workflow.
@gep13 gep13 added the Build label Jun 26, 2020
@gep13 gep13 self-assigned this Jun 26, 2020
@gep13
Copy link
Member Author

gep13 commented Jun 26, 2020

The line in question would be this one:

https://github.com/cake-build/cake/blob/develop/build.cake#L574

gep13 added a commit to gep13/cake that referenced this issue Jun 26, 2020
@gep13
(cake-buildGH-2814) Don't create prerelease GH release
d6222ab 
This causes problems when creating PR's into the Homebrew repository
and also when displaying releases within the GitHub UI.  There is no
real benefit to marking them as prerelease, so lets just not do it.
@gep13 gep13 mentioned this issue Jun 26, 2020
Closed
@devlead devlead added this to the v1.0.0 milestone Jun 29, 2020
pull bot pushed a commit to QaColony/cake-build_CI that referenced this issue Jun 29, 2020
@devlead
Merge branch 'gep13-feature/cake-buildGH-2814' into develop
3731637
@gep13 gep13 closed this as completed Jun 29, 2020
@dtrodrigues dtrodrigues mentioned this issue Jul 13, 2020
Merged
6 tasks
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Build
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2814: Don't create prerelease GH release gep13/cake
3 participants
@gep13 @devlead @cake-build-bot