Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase potential breaking change property #2930

Closed
devlead opened this issue Nov 5, 2020 · 4 comments · Fixed by #2940
Closed

Increase potential breaking change property #2930

devlead opened this issue Nov 5, 2020 · 4 comments · Fixed by #2940
Assignees
@pascalberger
Labels
Breaking change
Milestone
v1.0.0

Comments

@devlead
Copy link
Member

devlead commented Nov 5, 2020

@cake-build/cake-team shouldn't this be 1.0.0?

cake/src/Cake.Core/Constants.cs

Lines 11 to 12 in a719007

public static readonly Version LatestBreakingChange = new Version(0, 26, 0);
public static readonly Version LatestPotentialBreakingChange = new Version(0, 33, 0);

@devlead devlead added this to the v1.0.0 milestone Nov 5, 2020
@patriksvensson
Copy link
Member

Yes I think it should!

@bjorkstromm
Copy link
Member

Yes

@gep13 gep13 changed the title Increse potential breaking change Increase potential breaking change property Nov 6, 2020
pascalberger added a commit to pascalberger/cake that referenced this issue Nov 12, 2020
@pascalberger
(cake-buildGH-2930) Bump potential breaking change property to 1.0.0
0202eef
@pascalberger pascalberger mentioned this issue Nov 12, 2020
Merged
@pascalberger pascalberger linked a pull request Nov 12, 2020 that will close this issue
GH2930: Bump potential breaking change property to 1.0.0 #2940
Merged
@pascalberger pascalberger self-assigned this Nov 12, 2020
pascalberger added a commit to pascalberger/cake that referenced this issue Nov 27, 2020
@pascalberger
(cake-buildGH-2930) Bump potential breaking change property to 1.0.0
5034d83
devlead added a commit that referenced this issue Dec 1, 2020
@devlead
Merge branch 'pascalberger-feature/gh-2930' into release/1.0.0
65eedc9
@devlead
Copy link
Member Author

devlead commented Dec 1, 2020

Fixed by #2940

@devlead devlead closed this as completed Dec 1, 2020
@devlead devlead mentioned this issue Dec 19, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalberger pascalberger

Labels
Breaking change
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GH2930: Bump potential breaking change property to 1.0.0 pascalberger/cake
5 participants
@patriksvensson @devlead @pascalberger @bjorkstromm @cake-build-bot