GH2904: Frosting cake.config&tool config support #3059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devlead
commented
Jan 28, 2021
devlead
commented
- Frosting utilize CakeConfigurationProvider, enables config
- Frosting IServiceCollection.UseToolPath
- cake.config file
- environment variables
- command line arguments
- Tools path should be resolved using configuration
- fixes (Frosting) Tool installer should respect configuration #2904
devlead
force-pushed
the
feature/gh-2904
branch
from
1791819 to
2e51687
Compare
* Frosting utilize CakeConfigurationProvider, enables config
* Frosting IServiceCollection.UseToolPath
* cake.config file
* environment variables
* command line arguments
* Tools path should be resolved using configuration
* fixes cake-build#2904
devlead
force-pushed
the
feature/gh-2904
branch
from
2e51687 to
fe5d2aa
Compare
pascalberger
requested changes
Jan 29, 2021
There was a problem hiding this comment.
We should move this post 1.x and discuss first what approach we want to take with configuration in Frosting: Support it or not, only cake.config or another more extensible approach, if cake.config which settings, have update to documentation in place, etc. To do this properly would move a 1.0 release further out and we're currently at a place where we're ready to ship if we don't open a whole new can of worms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.