GH-3127: Add ResultsDirectory to VSTestSettings. (see #3127) #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soroshsabz
changed the title
|
@devlead Please review it :) thanks |
augustoproiete
requested changes
Feb 16, 2021
There was a problem hiding this comment.
Thanks @soroshsabz. LGTM.
Could you please squash the commits and rebase against latest develop?
|
@augustoproiete I done it. |
augustoproiete
approved these changes
Feb 16, 2021
| @@ -117,6 +117,11 @@ private ProcessArgumentBuilder GetArguments(IEnumerable<FilePath> assemblyPaths, | |||
| builder.AppendSwitchQuoted("/Diag", ":", settings.Diag.MakeAbsolute(_environment).FullPath); | |||
| } | |||
|
|
|||
| if (settings.ResultsDirectory != null) | |||
| { | |||
| builder.AppendSwitchQuoted("/ResultsDirectory", ":", settings.ResultsDirectory.MakeAbsolute(_environment).FullPath); | |||
There was a problem hiding this comment.
👍 Looks good / prior art
| /// Test results directory will be created in specified path if not exists. | ||
| /// VSTest.Console.exe flag <see href="https://docs.microsoft.com/en-us/visualstudio/test/vstest-console-options#ResultDirectory">/ResultsDirectory</see>. | ||
| /// </summary> | ||
| public DirectoryPath ResultsDirectory { get; set; } |
There was a problem hiding this comment.
👍 Matches command-line argument in VSTest-Console docs
|
@soroshsabz your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved #3127