GH-3143: Don't try to parse empty solution file lines #3147
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmbro
changed the title
nmbro
changed the title
augustoproiete
requested changes
Feb 16, 2021
augustoproiete
requested changes
Feb 16, 2021
There was a problem hiding this comment.
LGTM. @nmbro Could you squash the commits and rebase on top of latest develop?
No longer needed. I did it myself. Will merge after CI finishes.
(cake-buildGH-3143) Recreate the issue with a test
augustoproiete
force-pushed
the
GH-3143
branch
from
3d4ded5 to
ce9ebb7
Compare
|
@nmbro your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3143
Should I care about Rider changing unrelated lines of code in Resources.Designer.cs?