GH2578: Support version ranges with NuGet in-process installer #3240

gitfool · 2021-03-06T21:01:31Z

Fixes #2578. Derived from PR #2576 - brought up to date with some of my own tweaks and fixed integration tests.

gitfool · 2021-03-06T21:32:13Z

Interesting. The integration tests ran successfully for me locally but the build servers are failing as described here.

gitfool · 2021-03-07T20:48:47Z

No assemblies found after running content resolver:

2021-03-07T20:32:10.9905152Z ========================================
2021-03-07T20:32:10.9906011Z Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T20:32:10.9907105Z ========================================
2021-03-07T20:32:10.9908230Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T20:32:11.0087124Z Executing: "D:/a/cake/cake/tests/integration/tools/Cake/Cake.exe" "C:/Users/RUNNER~1/AppData/Local/Temp/1a5259c5-6914-4a91-9a0e-1d0d579cddf5.cake" --verbosity=Diagnostic
2021-03-07T20:32:11.5272760Z Looking for modules...
2021-03-07T20:32:11.5671243Z No modules found to install.
2021-03-07T20:32:11.5772631Z Module directory does not exist.
2021-03-07T20:32:11.5903701Z Analyzing build script...
2021-03-07T20:32:11.5940469Z Analyzing C:/Users/runneradmin/AppData/Local/Temp/1a5259c5-6914-4a91-9a0e-1d0d579cddf5.cake...
2021-03-07T20:32:11.6140806Z Processing build script...
2021-03-07T20:32:11.6177600Z Installing addins...
2021-03-07T20:32:11.7409483Z Missing C:\Users\runneradmin\.nuget\packages\serilog\2.6.0\serilog.2.6.0.nupkg
2021-03-07T20:32:12.0426102Z   GET https://api.nuget.org/v3/registration5-gz-semver2/serilog/index.json
2021-03-07T20:32:12.1843015Z   OK https://api.nuget.org/v3/registration5-gz-semver2/serilog/index.json 130ms
2021-03-07T20:32:12.2222229Z   GET https://api.nuget.org/v3/registration5-gz-semver2/serilog/page/2.5.0-dev-00817/2.8.1-dev-01052.json
2021-03-07T20:32:12.3102869Z   OK https://api.nuget.org/v3/registration5-gz-semver2/serilog/page/2.5.0-dev-00817/2.8.1-dev-01052.json 88ms
2021-03-07T20:32:12.6474844Z   GET https://api.nuget.org/v3-flatcontainer/serilog/2.6.0/serilog.2.6.0.nupkg
2021-03-07T20:32:12.6539543Z   OK https://api.nuget.org/v3-flatcontainer/serilog/2.6.0/serilog.2.6.0.nupkg 6ms
2021-03-07T20:32:12.6682015Z Acquiring lock for the installation of Serilog 2.6.0
2021-03-07T20:32:12.6825860Z Acquired lock for the installation of Serilog 2.6.0
2021-03-07T20:32:12.6829835Z Installing Serilog 2.6.0.
2021-03-07T20:32:12.8265944Z Completed installation of Serilog 2.6.0
2021-03-07T20:32:12.9879705Z Addin assemblies not found at C:/Users/RUNNER~1/AppData/Local/Temp/tools/Addins/Serilog.2.6.0.
2021-03-07T20:32:13.0161680Z Addin assemblies not found for tfm .NETFramework,Version=v4.6.1 and rid [NULL].
2021-03-07T20:32:13.0163237Z No assemblies found after running content resolver.
2021-03-07T20:32:13.0198512Z Error: Cake.Core.CakeException: Failed to install addin 'Serilog'.
2021-03-07T20:32:13.0201531Z    at Cake.Core.Scripting.ScriptProcessor.InstallAddins(IReadOnlyCollection`1 addins, DirectoryPath installPath)
2021-03-07T20:32:13.0204851Z    at Cake.Core.Scripting.ScriptRunner.Run(IScriptHost host, FilePath scriptPath)
2021-03-07T20:32:13.0211019Z    at Cake.Features.Building.BuildFeature.RunCore(IRemainingArguments arguments, BuildFeatureSettings settings)
2021-03-07T20:32:13.0213320Z    at Cake.Features.Building.BuildFeature.Run(IRemainingArguments arguments, BuildFeatureSettings settings)
2021-03-07T20:32:13.0215214Z    at Cake.Commands.DefaultCommand.Execute(CommandContext context, DefaultCommandSettings settings)
2021-03-07T20:32:13.0440532Z An error occurred when executing task 'Cake.NuGet.InProcessInstaller.VersionPinExact'.

gitfool · 2021-03-07T22:22:31Z

Using a TEMP subdirectory solved the issue:

2021-03-07T21:15:09.4378611Z ========================================
2021-03-07T21:15:09.4379422Z Cake.NuGet.InProcessInstaller.Setup
2021-03-07T21:15:09.4380252Z ========================================
2021-03-07T21:15:09.4381343Z Executing task: Cake.NuGet.InProcessInstaller.Setup
2021-03-07T21:15:09.4382832Z Creating directory D:/a/cake/cake/tests/integration/temp/Cake.NuGet.InProcessInstaller
2021-03-07T21:15:09.4384339Z Finished executing task: Cake.NuGet.InProcessInstaller.Setup
2021-03-07T21:15:09.4385182Z 
2021-03-07T21:15:09.4385638Z ========================================
2021-03-07T21:15:09.4386677Z Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T21:15:09.4387682Z ========================================
2021-03-07T21:15:09.4388887Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T21:15:09.4554023Z Executing: "D:/a/cake/cake/tests/integration/tools/Cake/Cake.exe" "D:/a/cake/cake/tests/integration/temp/Cake.NuGet.InProcessInstaller/build.cake" --verbosity=Diagnostic
2021-03-07T21:15:09.9912990Z Looking for modules...
2021-03-07T21:15:10.0302453Z No modules found to install.
2021-03-07T21:15:10.0401209Z Module directory does not exist.
2021-03-07T21:15:10.0530115Z Analyzing build script...
2021-03-07T21:15:10.0568522Z Analyzing D:/a/cake/cake/tests/integration/temp/Cake.NuGet.InProcessInstaller/build.cake...
2021-03-07T21:15:10.0716715Z Processing build script...
2021-03-07T21:15:10.0754851Z Installing addins...
2021-03-07T21:15:10.1989890Z Missing C:\Users\runneradmin\.nuget\packages\serilog\2.6.0\serilog.2.6.0.nupkg
2021-03-07T21:15:10.5107798Z   GET https://api.nuget.org/v3/registration5-gz-semver2/serilog/index.json
2021-03-07T21:15:10.6715758Z   OK https://api.nuget.org/v3/registration5-gz-semver2/serilog/index.json 149ms
2021-03-07T21:15:10.7111812Z   GET https://api.nuget.org/v3/registration5-gz-semver2/serilog/page/2.5.0-dev-00817/2.8.1-dev-01052.json
2021-03-07T21:15:10.7300841Z   OK https://api.nuget.org/v3/registration5-gz-semver2/serilog/page/2.5.0-dev-00817/2.8.1-dev-01052.json 19ms
2021-03-07T21:15:11.0762189Z   GET https://api.nuget.org/v3-flatcontainer/serilog/2.6.0/serilog.2.6.0.nupkg
2021-03-07T21:15:11.0893469Z   OK https://api.nuget.org/v3-flatcontainer/serilog/2.6.0/serilog.2.6.0.nupkg 13ms
2021-03-07T21:15:11.1035857Z Acquiring lock for the installation of Serilog 2.6.0
2021-03-07T21:15:11.1189930Z Acquired lock for the installation of Serilog 2.6.0
2021-03-07T21:15:11.1193590Z Installing Serilog 2.6.0.
2021-03-07T21:15:11.2575563Z Completed installation of Serilog 2.6.0
2021-03-07T21:15:11.3892780Z The addin Serilog will reference Serilog.dll.
2021-03-07T21:15:11.4058234Z Verifying assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'.
2021-03-07T21:15:11.4784561Z Adding assembly reference to mscorlib.dll...
2021-03-07T21:15:11.4786009Z Adding assembly reference to System.Core.dll...
2021-03-07T21:15:11.4787134Z Adding assembly reference to Microsoft.CSharp.dll...
2021-03-07T21:15:11.4788169Z Adding assembly reference to Cake.Core.dll...
2021-03-07T21:15:11.4789149Z Adding assembly reference to Cake.Common.dll...
2021-03-07T21:15:11.4790078Z Adding assembly reference to Cake.exe...
2021-03-07T21:15:11.4790970Z Adding assembly reference to System.dll...
2021-03-07T21:15:11.4791878Z Adding assembly reference to System.Xml.dll...
2021-03-07T21:15:11.4792893Z Adding assembly reference to System.Xml.Linq.dll...
2021-03-07T21:15:11.4793893Z Adding assembly reference to System.Data.dll...
2021-03-07T21:15:11.4794982Z Adding assembly reference to System.Runtime.dll...
2021-03-07T21:15:11.4796061Z Adding assembly reference to System.Collections.dll...
2021-03-07T21:15:11.4806170Z Adding assembly reference to System.Net.Http.dll...
2021-03-07T21:15:11.4807396Z Adding assembly reference to netstandard.dll...
2021-03-07T21:15:11.4808317Z Adding assembly reference to Serilog.dll...
2021-03-07T21:15:11.4812282Z Importing namespace Cake.Common...
2021-03-07T21:15:11.4813260Z Importing namespace Cake.Common.Build...
2021-03-07T21:15:11.4814335Z Importing namespace Cake.Common.Build.AppVeyor...
2021-03-07T21:15:11.4815732Z Importing namespace Cake.Common.Build.AppVeyor.Data...
2021-03-07T21:15:11.4817140Z Importing namespace Cake.Common.Build.AzurePipelines...
2021-03-07T21:15:11.4818650Z Importing namespace Cake.Common.Build.AzurePipelines.Data...
2021-03-07T21:15:11.4819996Z Importing namespace Cake.Common.Build.Bamboo...
2021-03-07T21:15:11.4821196Z Importing namespace Cake.Common.Build.Bamboo.Data...
2021-03-07T21:15:11.4822601Z Importing namespace Cake.Common.Build.BitbucketPipelines...
2021-03-07T21:15:11.4824252Z Importing namespace Cake.Common.Build.BitbucketPipelines.Data...
2021-03-07T21:15:11.4825743Z Importing namespace Cake.Common.Build.Bitrise...
2021-03-07T21:15:11.4826979Z Importing namespace Cake.Common.Build.Bitrise.Data...
2021-03-07T21:15:11.4828246Z Importing namespace Cake.Common.Build.ContinuaCI...
2021-03-07T21:15:11.4829581Z Importing namespace Cake.Common.Build.ContinuaCI.Data...
2021-03-07T21:15:11.4830939Z Importing namespace Cake.Common.Build.GitHubActions...
2021-03-07T21:15:11.4832615Z Importing namespace Cake.Common.Build.GitHubActions.Data...
2021-03-07T21:15:11.4834011Z Importing namespace Cake.Common.Build.GitLabCI...
2021-03-07T21:15:11.4835622Z Importing namespace Cake.Common.Build.GitLabCI.Data...
2021-03-07T21:15:11.4836826Z Importing namespace Cake.Common.Build.GoCD...
2021-03-07T21:15:11.4838009Z Importing namespace Cake.Common.Build.GoCD.Data...
2021-03-07T21:15:11.4839181Z Importing namespace Cake.Common.Build.Jenkins...
2021-03-07T21:15:11.4840414Z Importing namespace Cake.Common.Build.Jenkins.Data...
2021-03-07T21:15:11.4841608Z Importing namespace Cake.Common.Build.MyGet...
2021-03-07T21:15:11.4842759Z Importing namespace Cake.Common.Build.TeamCity...
2021-03-07T21:15:11.4843935Z Importing namespace Cake.Common.Build.TravisCI...
2021-03-07T21:15:11.4845261Z Importing namespace Cake.Common.Build.TravisCI.Data...
2021-03-07T21:15:11.4846460Z Importing namespace Cake.Common.Diagnostics...
2021-03-07T21:15:11.4847455Z Importing namespace Cake.Common.IO...
2021-03-07T21:15:11.4848415Z Importing namespace Cake.Common.IO.Paths...
2021-03-07T21:15:11.4849425Z Importing namespace Cake.Common.Net...
2021-03-07T21:15:11.4850392Z Importing namespace Cake.Common.Security...
2021-03-07T21:15:11.4851453Z Importing namespace Cake.Common.Solution...
2021-03-07T21:15:11.4852582Z Importing namespace Cake.Common.Solution.Project...
2021-03-07T21:15:11.4854057Z Importing namespace Cake.Common.Solution.Project.Properties...
2021-03-07T21:15:11.4855773Z Importing namespace Cake.Common.Solution.Project.XmlDoc...
2021-03-07T21:15:11.4857002Z Importing namespace Cake.Common.Text...
2021-03-07T21:15:11.4858011Z Importing namespace Cake.Common.Tools.Cake...
2021-03-07T21:15:11.4859186Z Importing namespace Cake.Common.Tools.Chocolatey...
2021-03-07T21:15:11.4860553Z Importing namespace Cake.Common.Tools.Chocolatey.ApiKey...
2021-03-07T21:15:11.4862090Z Importing namespace Cake.Common.Tools.Chocolatey.Config...
2021-03-07T21:15:11.4863585Z Importing namespace Cake.Common.Tools.Chocolatey.Download...
2021-03-07T21:15:11.4865226Z Importing namespace Cake.Common.Tools.Chocolatey.Features...
2021-03-07T21:15:11.4866782Z Importing namespace Cake.Common.Tools.Chocolatey.Install...
2021-03-07T21:15:11.4868247Z Importing namespace Cake.Common.Tools.Chocolatey.New...
2021-03-07T21:15:11.4869652Z Importing namespace Cake.Common.Tools.Chocolatey.Pack...
2021-03-07T21:15:11.4871021Z Importing namespace Cake.Common.Tools.Chocolatey.Pin...
2021-03-07T21:15:11.4872421Z Importing namespace Cake.Common.Tools.Chocolatey.Push...
2021-03-07T21:15:11.4873901Z Importing namespace Cake.Common.Tools.Chocolatey.Sources...
2021-03-07T21:15:11.4878142Z Importing namespace Cake.Common.Tools.Chocolatey.Uninstall...
2021-03-07T21:15:11.4879752Z Importing namespace Cake.Common.Tools.Chocolatey.Upgrade...
2021-03-07T21:15:11.4881090Z Importing namespace Cake.Common.Tools.DotCover...
2021-03-07T21:15:11.4882621Z Importing namespace Cake.Common.Tools.DotCover.Analyse...
2021-03-07T21:15:11.4884023Z Importing namespace Cake.Common.Tools.DotCover.Cover...
2021-03-07T21:15:11.4885589Z Importing namespace Cake.Common.Tools.DotCover.Merge...
2021-03-07T21:15:11.4886970Z Importing namespace Cake.Common.Tools.DotCover.Report...
2021-03-07T21:15:11.4888307Z Importing namespace Cake.Common.Tools.DotNetCore...
2021-03-07T21:15:11.4889657Z Importing namespace Cake.Common.Tools.DotNetCore.Build...
2021-03-07T21:15:11.4891252Z Importing namespace Cake.Common.Tools.DotNetCore.BuildServer...
2021-03-07T21:15:11.4892841Z Importing namespace Cake.Common.Tools.DotNetCore.Clean...
2021-03-07T21:15:11.4894354Z Importing namespace Cake.Common.Tools.DotNetCore.Execute...
2021-03-07T21:15:11.4896214Z Importing namespace Cake.Common.Tools.DotNetCore.MSBuild...
2021-03-07T21:15:11.4898017Z Importing namespace Cake.Common.Tools.DotNetCore.NuGet.Delete...
2021-03-07T21:15:11.4899765Z Importing namespace Cake.Common.Tools.DotNetCore.NuGet.Push...
2021-03-07T21:15:11.4901476Z Importing namespace Cake.Common.Tools.DotNetCore.NuGet.Source...
2021-03-07T21:15:11.4903075Z Importing namespace Cake.Common.Tools.DotNetCore.Pack...
2021-03-07T21:15:11.4904635Z Importing namespace Cake.Common.Tools.DotNetCore.Publish...
2021-03-07T21:15:11.4906211Z Importing namespace Cake.Common.Tools.DotNetCore.Restore...
2021-03-07T21:15:11.4907767Z Importing namespace Cake.Common.Tools.DotNetCore.Run...
2021-03-07T21:15:11.4909373Z Importing namespace Cake.Common.Tools.DotNetCore.Test...
2021-03-07T21:15:11.4910813Z Importing namespace Cake.Common.Tools.DotNetCore.Tool...
2021-03-07T21:15:11.4912325Z Importing namespace Cake.Common.Tools.DotNetCore.VSTest...
2021-03-07T21:15:11.4913718Z Importing namespace Cake.Common.Tools.DupFinder...
2021-03-07T21:15:11.4914936Z Importing namespace Cake.Common.Tools.Fixie...
2021-03-07T21:15:11.4916089Z Importing namespace Cake.Common.Tools.GitLink...
2021-03-07T21:15:11.4917425Z Importing namespace Cake.Common.Tools.GitReleaseManager...
2021-03-07T21:15:11.4919164Z Importing namespace Cake.Common.Tools.GitReleaseManager.AddAssets...
2021-03-07T21:15:11.4921009Z Importing namespace Cake.Common.Tools.GitReleaseManager.Close...
2021-03-07T21:15:11.4922816Z Importing namespace Cake.Common.Tools.GitReleaseManager.Create...
2021-03-07T21:15:11.4924735Z Importing namespace Cake.Common.Tools.GitReleaseManager.Discard...
2021-03-07T21:15:11.4926604Z Importing namespace Cake.Common.Tools.GitReleaseManager.Export...
2021-03-07T21:15:11.4928412Z Importing namespace Cake.Common.Tools.GitReleaseManager.Label...
2021-03-07T21:15:11.4930171Z Importing namespace Cake.Common.Tools.GitReleaseManager.Open...
2021-03-07T21:15:11.4931962Z Importing namespace Cake.Common.Tools.GitReleaseManager.Publish...
2021-03-07T21:15:11.4933605Z Importing namespace Cake.Common.Tools.GitReleaseNotes...
2021-03-07T21:15:11.4935019Z Importing namespace Cake.Common.Tools.GitVersion...
2021-03-07T21:15:11.4936359Z Importing namespace Cake.Common.Tools.ILMerge...
2021-03-07T21:15:11.4937526Z Importing namespace Cake.Common.Tools.ILRepack...
2021-03-07T21:15:11.4938849Z Importing namespace Cake.Common.Tools.InnoSetup...
2021-03-07T21:15:11.4940100Z Importing namespace Cake.Common.Tools.InspectCode...
2021-03-07T21:15:11.4941333Z Importing namespace Cake.Common.Tools.MSBuild...
2021-03-07T21:15:11.4942468Z Importing namespace Cake.Common.Tools.MSpec...
2021-03-07T21:15:11.4943630Z Importing namespace Cake.Common.Tools.MSTest...
2021-03-07T21:15:11.4957171Z Importing namespace Cake.Common.Tools.NSIS...
2021-03-07T21:15:11.4958331Z Importing namespace Cake.Common.Tools.NuGet...
2021-03-07T21:15:11.4959605Z Importing namespace Cake.Common.Tools.NuGet.Add...
2021-03-07T21:15:11.4960871Z Importing namespace Cake.Common.Tools.NuGet.Delete...
2021-03-07T21:15:11.4962141Z Importing namespace Cake.Common.Tools.NuGet.Init...
2021-03-07T21:15:11.4963422Z Importing namespace Cake.Common.Tools.NuGet.Install...
2021-03-07T21:15:11.4965127Z Importing namespace Cake.Common.Tools.NuGet.List...
2021-03-07T21:15:11.4966424Z Importing namespace Cake.Common.Tools.NuGet.Pack...
2021-03-07T21:15:11.4967650Z Importing namespace Cake.Common.Tools.NuGet.Push...
2021-03-07T21:15:11.4968934Z Importing namespace Cake.Common.Tools.NuGet.Restore...
2021-03-07T21:15:11.4970291Z Importing namespace Cake.Common.Tools.NuGet.SetApiKey...
2021-03-07T21:15:11.4971733Z Importing namespace Cake.Common.Tools.NuGet.SetProxy...
2021-03-07T21:15:11.4973072Z Importing namespace Cake.Common.Tools.NuGet.Sources...
2021-03-07T21:15:11.4974479Z Importing namespace Cake.Common.Tools.NuGet.Update...
2021-03-07T21:15:11.4975665Z Importing namespace Cake.Common.Tools.NUnit...
2021-03-07T21:15:11.4976883Z Importing namespace Cake.Common.Tools.OctopusDeploy...
2021-03-07T21:15:11.4978144Z Importing namespace Cake.Common.Tools.OpenCover...
2021-03-07T21:15:11.4979473Z Importing namespace Cake.Common.Tools.ReportGenerator...
2021-03-07T21:15:11.4980790Z Importing namespace Cake.Common.Tools.ReportUnit...
2021-03-07T21:15:11.4982060Z Importing namespace Cake.Common.Tools.Roundhouse...
2021-03-07T21:15:11.4983269Z Importing namespace Cake.Common.Tools.SignTool...
2021-03-07T21:15:11.4984650Z Importing namespace Cake.Common.Tools.SpecFlow...
2021-03-07T21:15:11.4986326Z Importing namespace Cake.Common.Tools.SpecFlow.StepDefinitionReport...
2021-03-07T21:15:11.4988307Z Importing namespace Cake.Common.Tools.SpecFlow.TestExecutionReport...
2021-03-07T21:15:11.4989958Z Importing namespace Cake.Common.Tools.TextTransform...
2021-03-07T21:15:11.4991163Z Importing namespace Cake.Common.Tools.VSTest...
2021-03-07T21:15:11.4992306Z Importing namespace Cake.Common.Tools.VSWhere...
2021-03-07T21:15:11.4993497Z Importing namespace Cake.Common.Tools.VSWhere.All...
2021-03-07T21:15:11.4994903Z Importing namespace Cake.Common.Tools.VSWhere.Latest...
2021-03-07T21:15:11.4996441Z Importing namespace Cake.Common.Tools.VSWhere.Legacy...
2021-03-07T21:15:11.4997866Z Importing namespace Cake.Common.Tools.VSWhere.Product...
2021-03-07T21:15:11.4999198Z Importing namespace Cake.Common.Tools.WiX...
2021-03-07T21:15:11.5000308Z Importing namespace Cake.Common.Tools.WiX.Heat...
2021-03-07T21:15:11.5001461Z Importing namespace Cake.Common.Tools.XBuild...
2021-03-07T21:15:11.5002560Z Importing namespace Cake.Common.Tools.XUnit...
2021-03-07T21:15:11.5003565Z Importing namespace Cake.Common.Xml...
2021-03-07T21:15:11.5004473Z Importing namespace Cake.Core...
2021-03-07T21:15:11.5005420Z Importing namespace Cake.Core.Diagnostics...
2021-03-07T21:15:11.5006402Z Importing namespace Cake.Core.IO...
2021-03-07T21:15:11.5007343Z Importing namespace Cake.Core.Scripting...
2021-03-07T21:15:11.5008217Z Importing namespace System...
2021-03-07T21:15:11.5009231Z Importing namespace System.Collections.Generic...
2021-03-07T21:15:11.5010216Z Importing namespace System.IO...
2021-03-07T21:15:11.5011047Z Importing namespace System.Linq...
2021-03-07T21:15:11.5011879Z Importing namespace System.Text...
2021-03-07T21:15:11.5012850Z Importing namespace System.Threading.Tasks...
2021-03-07T21:15:11.6599780Z Resolving assembly System.Runtime.Loader, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
2021-03-07T21:15:11.6622314Z Exception while resolving assembly System.Runtime.Loader: Could not load file or assembly 'System.Runtime.Loader' or one of its dependencies. The system cannot find the file specified.
2021-03-07T21:15:11.6679662Z Compiling build script...
2021-03-07T21:15:16.5797786Z Resolving assembly Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10
2021-03-07T21:15:16.5799464Z Resolved Serilog by assembly Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10
2021-03-07T21:15:16.5815639Z Requested NuGet version: 2.6.0
2021-03-07T21:15:16.5816454Z Loaded NuGet version: 2.6.0.0
2021-03-07T21:15:16.6081671Z Finished executing task: Cake.NuGet.InProcessInstaller.VersionPinExact

gitfool · 2021-03-07T23:41:28Z

Extract from relevant integration tests with diagnostics logging:

2021-03-07T21:15:09.4385638Z ========================================
2021-03-07T21:15:09.4386677Z Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T21:15:09.4387682Z ========================================
2021-03-07T21:15:09.4388887Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T21:15:10.0530115Z Analyzing build script...
2021-03-07T21:15:10.0754851Z Installing addins...
2021-03-07T21:15:11.1193590Z Installing Serilog 2.6.0.
2021-03-07T21:15:11.2575563Z Completed installation of Serilog 2.6.0
2021-03-07T21:15:11.3892780Z The addin Serilog will reference Serilog.dll.
2021-03-07T21:15:11.4058234Z Verifying assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'.
2021-03-07T21:15:16.5815639Z Requested NuGet version: 2.6.0
2021-03-07T21:15:16.5816454Z Loaded NuGet version: 2.6.0.0
2021-03-07T21:15:16.6081671Z Finished executing task: Cake.NuGet.InProcessInstaller.VersionPinExact
2021-03-07T21:15:16.6083095Z 
2021-03-07T21:15:16.6083684Z ========================================
2021-03-07T21:15:16.6085232Z Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveExclusive
2021-03-07T21:15:16.6086922Z ========================================
2021-03-07T21:15:16.6088773Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveExclusive
2021-03-07T21:15:17.2180209Z Analyzing build script...
2021-03-07T21:15:17.2418241Z Installing addins...
2021-03-07T21:15:18.5458915Z Installing Serilog 2.5.0.
2021-03-07T21:15:18.7644863Z Completed installation of Serilog 2.5.0
2021-03-07T21:15:18.9019066Z The addin Serilog will reference Serilog.dll.
2021-03-07T21:15:18.9196765Z Verifying assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'.
2021-03-07T21:15:24.0680121Z Requested NuGet version: [2.5.0,2.6.0)
2021-03-07T21:15:24.0680919Z Loaded NuGet version: 2.5.0.0
2021-03-07T21:15:24.0959473Z Finished executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveExclusive
2021-03-07T21:15:24.0961735Z 
2021-03-07T21:15:24.0962306Z ========================================
2021-03-07T21:15:24.0963885Z Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveInclusive
2021-03-07T21:15:24.0965543Z ========================================
2021-03-07T21:15:24.0967289Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveInclusive
2021-03-07T21:15:24.7156404Z Analyzing build script...
2021-03-07T21:15:24.7384736Z Installing addins...
2021-03-07T21:15:25.9063946Z Installing Serilog 2.3.0.
2021-03-07T21:15:26.0864300Z Completed installation of Serilog 2.3.0
2021-03-07T21:15:26.2227948Z The addin Serilog will reference Serilog.dll.
2021-03-07T21:15:26.2398480Z Verifying assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'.
2021-03-07T21:15:31.3795549Z Requested NuGet version: [2.3.0,2.4.0]
2021-03-07T21:15:31.3796318Z Loaded NuGet version: 2.3.0.0
2021-03-07T21:15:31.4090551Z Finished executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.InclusiveInclusive
2021-03-07T21:15:31.4092692Z 
2021-03-07T21:15:31.4094826Z ========================================
2021-03-07T21:15:31.4097481Z Cake.NuGet.InProcessInstaller.VersionPinRange.Wildcard
2021-03-07T21:15:31.4098847Z ========================================
2021-03-07T21:15:31.4100353Z Executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.Wildcard
2021-03-07T21:15:32.0246831Z Analyzing build script...
2021-03-07T21:15:32.0469206Z Installing addins...
2021-03-07T21:15:33.2097268Z Installing Serilog 2.2.1.
2021-03-07T21:15:33.3855648Z Completed installation of Serilog 2.2.1
2021-03-07T21:15:33.5222173Z The addin Serilog will reference Serilog.dll.
2021-03-07T21:15:33.5389026Z Verifying assembly 'Serilog, Version=2.0.0.0, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'.
2021-03-07T21:15:38.6528191Z Requested NuGet version: [2.2.*,2.3.0)
2021-03-07T21:15:38.6529017Z Loaded NuGet version: 2.2.1.0
2021-03-07T21:15:38.6817919Z Finished executing task: Cake.NuGet.InProcessInstaller.VersionPinRange.Wildcard

See logs_975.zip for the full logs from successful build with diagnostics logging.

Also, note that NuGet dependency resolution rules seem to be using "lowest applicable version" to resolve version [2.3.0,2.4.0] in VersionPinRange.InclusiveInclusive.

@augustoproiete ready for review.

gitfool · 2021-03-08T20:10:53Z

Unrelated build failure in macos-latest:

2021-03-08T19:48:58.5777150Z ----------------------------------------
2021-03-08T19:48:58.5777640Z Teardown
2021-03-08T19:48:58.5778430Z ----------------------------------------
2021-03-08T19:48:58.5786430Z Starting Teardown...
2021-03-08T19:48:58.5787820Z Finished running tasks.
2021-03-08T19:48:58.5814550Z Error: One or more errors occurred. (.NET Core CLI: Process returned an error (exit code 1).)
2021-03-08T19:48:58.5816140Z 	.NET Core CLI: Process returned an error (exit code 1).
2021-03-08T19:48:58.6121560Z ##[error]The process 'tools/dotnet-cake' failed with exit code 1

I've seen this before; seems to happen randomly.

src/Directory.Build.props

tests/integration/Cake.NuGet/InProcessInstaller.cake

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version

gitfool · 2021-03-09T09:55:55Z

@devlead ready for a final review when the checks pass.

devlead

LGTM 👍

devlead · 2021-03-09T10:17:24Z

@gitfool your changes have been merged, thanks for your contribution 👍

augustoproiete added this to the v1.x Next Candidate milestone Mar 6, 2021

augustoproiete added the Response from Cake team required label Mar 6, 2021

gitfool force-pushed the gh2578 branch 2 times, most recently from 0e95c81 to 0692946 Compare March 7, 2021 20:23

gitfool force-pushed the gh2578 branch from 15ff71a to 2ad44db Compare March 7, 2021 22:35

augustoproiete added the Ready For Review label Mar 8, 2021

gitfool mentioned this pull request Mar 8, 2021

Debug/Diagnostic color is far too dark #3245

Open

gitfool force-pushed the gh2578 branch from 2ad44db to 710bdd9 Compare March 8, 2021 19:41

devlead force-pushed the gh2578 branch from 710bdd9 to 6bf184c Compare March 9, 2021 08:08

devlead reviewed Mar 9, 2021

View reviewed changes

src/Directory.Build.props Outdated Show resolved Hide resolved

devlead requested changes Mar 9, 2021

View reviewed changes

tests/integration/Cake.NuGet/InProcessInstaller.cake Outdated Show resolved Hide resolved

tests/integration/Cake.NuGet/InProcessInstaller.cake Outdated Show resolved Hide resolved

gitfool force-pushed the gh2578 branch from 6bf184c to 12b43db Compare March 9, 2021 08:48

gitfool added 2 commits March 9, 2021 22:20

Use default lang version for all projects

3e79c63

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version

Support version ranges with NuGet in-process installer

24d8a5e

gitfool force-pushed the gh2578 branch from 12b43db to 24d8a5e Compare March 9, 2021 09:34

devlead approved these changes Mar 9, 2021

View reviewed changes

devlead removed this from the v1.x Next Candidate milestone Mar 9, 2021

devlead merged commit 364e922 into cake-build:develop Mar 9, 2021

gitfool deleted the gh2578 branch March 9, 2021 10:18

devlead mentioned this pull request Mar 9, 2021

GH-2578: Support version ranges for referenced nuget packages #2576

Closed

augustoproiete removed Ready For Review Response from Cake team required labels Mar 9, 2021

pascalberger mentioned this pull request Mar 9, 2021

Document NuGet version range support cake-build/website#1766

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH2578: Support version ranges with NuGet in-process installer #3240

GH2578: Support version ranges with NuGet in-process installer #3240

gitfool commented Mar 6, 2021

gitfool commented Mar 6, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 8, 2021

gitfool commented Mar 9, 2021

devlead left a comment

devlead commented Mar 9, 2021

GH2578: Support version ranges with NuGet in-process installer #3240

GH2578: Support version ranges with NuGet in-process installer #3240

Conversation

gitfool commented Mar 6, 2021

gitfool commented Mar 6, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 7, 2021

gitfool commented Mar 8, 2021

gitfool commented Mar 9, 2021

devlead left a comment

Choose a reason for hiding this comment

devlead commented Mar 9, 2021