Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cake Watch Advance #201

Merged
merged 2 commits into from
Oct 3, 2021
Merged

Remove Cake Watch Advance #201

merged 2 commits into from
Oct 3, 2021

Conversation

TomerPacific
Copy link
Contributor

@TomerPacific TomerPacific commented Oct 3, 2021

Related to this issue from the Cake-Build website repository.

Following the specifications, Cake.Watch_Advance was added to the exclusion list.

This is the first step out of two to remove Cake.Watch_Advance from the website component.

@pascalberger

@gep13
Copy link
Member

gep13 commented Oct 3, 2021

@Jericho regarding the build failure, should we exclude this task from PR builds?

Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One smaller suggestion. Otherwise LGTM

Source/Cake.AddinDiscoverer/exclusionlist.json Outdated Show resolved Hide resolved
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TomerPacific
Copy link
Contributor Author

Awesome. Thanks @pascalberger. Where do we go from here regarding the original issue?

@Jericho
Copy link
Member

Jericho commented Oct 3, 2021

@Jericho regarding the build failure, should we exclude this task from PR builds?

Yes indeed. I'll improve the build script to avoid running the discoverer when a PR is submitted.

@Jericho
Copy link
Member

Jericho commented Oct 3, 2021

Looks good to me!

Thank you for your contribution.

@Jericho Jericho merged commit cd8f50c into cake-contrib:develop Oct 3, 2021
@TomerPacific TomerPacific deleted the feature/remove-cake-watch-advance-2116 branch October 4, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants