Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x phpstan 7 #994

Merged
merged 2 commits into from
Mar 4, 2024
Merged

5.x phpstan 7 #994

merged 2 commits into from
Mar 4, 2024

Conversation

dereuromark
Copy link
Member

Needed to go to L8 soon.

@dereuromark dereuromark added this to the 5.x milestone Mar 2, 2024
@dereuromark dereuromark mentioned this pull request Mar 2, 2024
Merged
@dereuromark
Copy link
Member Author

3 remaining issues:

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   Model/Table/SqlTraceTrait.php (in context of class DebugKit\Model\Table\PanelsTable)                                                                                  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  93     Method DebugKit\Model\Table\PanelsTable::fileStamp() should return T of Cake\ORM\Query\DeleteQuery|Cake\ORM\Query\SelectQuery|Cake\ORM\Query\UpdateQuery but returns  
         Cake\ORM\Query\DeleteQuery|Cake\ORM\Query\SelectQuery|Cake\ORM\Query\UpdateQuery.                                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   Model/Table/SqlTraceTrait.php (in context of class DebugKit\Model\Table\RequestsTable)                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
  93     Method DebugKit\Model\Table\RequestsTable::fileStamp() should return T of Cake\ORM\Query\DeleteQuery|Cake\ORM\Query\SelectQuery|Cake\ORM\Query\UpdateQuery but returns  
         Cake\ORM\Query\DeleteQuery|Cake\ORM\Query\SelectQuery|Cake\ORM\Query\UpdateQuery.                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------- 
  Line   Panel/VariablesPanel.php                            
 ------ ---------------------------------------------------- 
  68     Call to an undefined method object::__debugInfo().  
 ------ ----------------------------------------------------

othercorey
othercorey reviewed Mar 4, 2024
View reviewed changes
src/Mailer/Transport/DebugKitTransport.php
/** @var callable $callable */
$callable = [$this->originalTransport, $method];

return call_user_func_array($callable, $args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could replace this with a first-class callable. $this->originalTransport->$method(...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, u wanna add the commit on top? Currently not on the computer

@markstory markstory merged commit 3afc62e into 5.x Mar 4, 2024
8 checks passed
@markstory markstory deleted the 5.x-phpstan-7 branch March 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@othercorey othercorey othercorey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @othercorey @markstory