Fix invalid SVG error when using special char in layer lable #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @caksoylar,
This is a super quick PR to fix an issue with string escape. I have a layer called
<^v>
(my nav layer), and it causes issues with the draw function.The draw function would not see any error, but the resulting SVG is invalid. This is the error
The fix was super quick, I just used your pre-existing
escape
function to escape the name. I tested it and it works as expected.One thing to note: I couldn't see where the layer styling class is actually used 🤔. So it is now correctly escaped, but it appears the classname isn't used anywhere. So, either it is indeed not used, and that's fine. Or it is used somewhere and I missed it. In which case, let me know where and I'll update the PR.
Thank you for your work 🙏