Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing back - "SCE Pilot- Upgrading CAVA pilot to focus on batch mode to reduce code complexity" #447

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

claalmve
Copy link
Collaborator

@claalmve claalmve commented Oct 7, 2024

Description of PR

Summary of changes and related issue

Reverts #443. This is to debug a new and improved batch mode using LOCA data. Theoretically, if this is debugged, this PRs integration into vulnerability.py should reduce the space/time complexities of cava_data and also make the back-end code much more readable and useable.

Relevant motivation and context

This is introduced again so that debugging LOCA batch mode functionality can be more easily done and we can eventually push in a much cleaner, more streamlined cava_data.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Definition of Done Checklist

Practical

  • 80% unit test coverage
  • Documentation
    • All functions/adjusted functions documented in the readthedocs.
    • Documentation is pushed
  • Complex code commented
  • Naming conventions followed
    • Helper functions hidden with _ before the name
  • Context of function is clearly provided
    • Intent of function is provided
    • How to test, so that it is not siloed on scientists and anyone can review
    • Appropriate manual testing was completed
  • Any notebooks known to utilize the affected functions are still working
  • Linting completed and resolved

Conceptual

  • Doesn't replicate existing functionality
  • Aligns with general coding standard of existing functions
  • Matches desired functinonality from users/scientists

@mdkoenig
Copy link

Improve batch mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants