Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.1 Release + misc fixes #52

Merged
merged 21 commits into from
Apr 23, 2020
Merged

v1.1.1 Release + misc fixes #52

merged 21 commits into from
Apr 23, 2020

Conversation

wangannie
Copy link
Member

What's new in this PR

  • Updated to Expo SDK 37
    • Changed to expo-screen-orientation
  • Updated splash screen and app icon image -- fixed Bug Squash Fang Notes #40 (partially?)
    • Fixed issue where the image was cut off on Android (from Avery)
  • Updated point constants for Nam's launch
  • Fixed bugs:
  • Fixed inconsistent KeyboardAvoidingView behavior
  • Bumped version codes

Relevant Links

Online sources

https://dev.to/expo/expo-sdk-37-is-now-available-69g

Related PRs

How to review

  • Focus on testing that everything in Auth and QTY modal properly avoids the keyboard on iOS, Android if you have access
  • Make sure I've updated the dependencies correctly for SDK37

Next steps

  • I could not figure out how to get screen orientation to lock for iOS (it works fine on Android).
  • Make the build

Tests Performed, Edge Cases

Screenshots

CC: @anniero98 @wangannie

@wangannie wangannie requested review from JustinMi and annieyro April 20, 2020 04:51
Copy link
Contributor

@annieyro annieyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@wangannie wangannie merged commit e94549c into master Apr 23, 2020
@wangannie wangannie deleted the AnnieW/release branch April 23, 2020 02:58
@wangannie wangannie linked an issue May 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants