Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android hide password #121

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Android hide password #121

merged 4 commits into from
Apr 20, 2020

Conversation

wangannie
Copy link
Member

@wangannie wangannie commented Apr 19, 2020

What's new in this PR

Relevant Links

Online sources

secureTextEntry has known issues with some keyboardTypes, but not default. For some reason, setting to default wouldn't work, but undefined works.

Related PRs

How to review

On Android, use this link https://exp.host/@wangannie/healthy-corners-rewards-android_auth_fixes to open the published project directly in the Expo app.

  • Test to see that the password is correctly hidden for Login and Signup on Android.
  • Try opening Nam's Market and a few other stores in Google Maps and make sure it takes you to the one in DC.

Next steps

Tests Performed, Edge Cases

Screenshots

Opening Nam's works properly even when the simulator location is set in Berkeley. Update: removed this
https://www.loom.com/share/e869667902c3469daa7ad970e481dfbc

CC: @anniero98

@wangannie wangannie requested review from JustinMi and aceschen April 19, 2020 20:44
Copy link
Contributor

@aceschen aceschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Password hiding works on both log in and sign up
  • Google maps directions take me to the right coordinates

Copy link
Contributor

@JustinMi JustinMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@wangannie wangannie changed the title Android hide password, Google maps directions fix Android hide password Apr 20, 2020
@wangannie wangannie merged commit a0cc185 into master Apr 20, 2020
@wangannie wangannie deleted the AnnieW/android_auth_fixes branch April 20, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants