Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
keyboardType
was interfering withsecureTextEntry
on Android and passwords were not hidden.where some stores would open directions to the wrong area if the store name matched something closer to the user's current location.Since the forcelatlon fix would pull up the store with ONLY lat/lon without the name (less intuitive), we decided not to address this since it would not be an issue for real users (individuals living in DC).Relevant Links
Online sources
secureTextEntry
has known issues with somekeyboardType
s, but not default. For some reason, setting to default wouldn't work, butundefined
works.Related PRs
How to review
On Android, use this link https://exp.host/@wangannie/healthy-corners-rewards-android_auth_fixes to open the published project directly in the Expo app.
Next steps
Tests Performed, Edge Cases
Screenshots
Opening Nam's works properly even when the simulator location is set in Berkeley.Update: removed thishttps://www.loom.com/share/e869667902c3469daa7ad970e481dfbc
CC: @anniero98