Implement basic encryption for passwords #130
Merged
+63
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangannie
approved these changes
Apr 23, 2020
lvlcfm
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
expo-cryptoto 'encrypt' passwords. We store only a hash. Salt is taken from Airtable-generated record IDs (see code for details).Relevant Links
Online sources
https://docs.expo.io/versions/latest/sdk/crypto/
If you haven't taken CS161 yet:
https://auth0.com/blog/adding-salt-to-hashing-a-better-way-to-store-passwords/
Related PRs
How to review
Sign up and login. You'll need to keep track of your passwords to log in so don't type gibberish!
Next steps
Push OTA updates to both live apps.
Eventually we'll either integrate with Airlock or disable password functionality entirely. We'll discuss further as a team
Screenshots
CC: @wangannie @FranCogMents