Program tag components #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyro
requested changes
Apr 30, 2020
wangannie
requested changes
Apr 30, 2020
| // i.e. "WIC" was entered as "WIc" or "SNAP Match" was entered as "snap Match" | ||
| // Hopefully ensures that chips will work most of the time, only not displaying if | ||
| // they enter the wrong string of words | ||
| if ( |
There was a problem hiding this comment.
Nice that you considered these cases, but wouldn't this input only come from within our code? Why would we need this here?
There was a problem hiding this comment.
I figured that the program name gets passed from so many sources (i.e. store card, store details, store list and maybe more in the future) so if there's ever a case someone spells it wrong or something it would still work ?? it's a bit extra but i guess it ensures that the chips still function correctly even if there's a small capitalization error in the code
There was a problem hiding this comment.
i agree with this sentiment much human error
wangannie
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
How to review
Verify that chips still appear correctly in the
StoreCardandStoreDetailsScreenandStoresList.Verify that stores like "BP Blair" have the default text for no programs available.
Relevant Links
Online sources
Related PRs
#98
Next steps
Screenshots
CC: @anniero98 @wangannie