Fixed accepted program description wrap issue #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethlien
approved these changes
Apr 29, 2020
screens/map/StoreDetailsScreen.js
Outdated
| @@ -3,7 +3,6 @@ import { Linking } from 'expo'; | |||
| import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
| import { ScrollView, TouchableOpacity, View } from 'react-native'; | |||
| import { Chip } from 'react-native-paper'; | |||
There was a problem hiding this comment.
it's ok he just moved files : ' ) he's in a better place now :' )
wangannie
approved these changes
Apr 30, 2020
…chen into thu/wrap-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
How to review
Navigate to the store details screen for various stores and verify that the text is wrapping correctly and that everything looks clean.
Notable stores: Grubb's (has SNAP Match, EBT, WIC) and Nam's (has Healthy Rewards)
Relevant Links
Online sources
Related PRs
#98
Next steps
Store details screen is pretty much done after this, I think!
NOTE: Vertical text alignment in chips might be a hard issue to fix and probably won't be a priority given how much time we have left. It also doesn't really affect readability or accessibility. On some phones like mine, the bug might not show up, so maybe we can backlog it?
Screenshots
CC: @anniero98 @wangannie