Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed edge cases with store hours #141

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fixed edge cases with store hours #141

merged 1 commit into from
Apr 30, 2020

Conversation

thumn
Copy link
Contributor

@thumn thumn commented Apr 30, 2020

What's new in this PR

Fixed two edge cases with store hours

  • Store is opening later today (e.g. current time is 7:30am, and store opens at 8:30am) --> displays "Closed until today 8:30am"
  • Store closes during am hours the next day (e.g. current time is 11pm, and store closes at 5am the next day) --> displays "Open until 5am"

How to review

I changed Market 77's hours to be "9pm-5am Daily" as an edge case. Check out the store hours for that store to make sure that (1) the store summary string makes sense and (2) the correct day is bolded in the schedule.

Relevant Links

Online sources

Related PRs

#96
Closes #140

Next steps

Just...lmk if there are more store hours bugs I guess...

Screenshots

IMG_2783
IMG_2784

CC: @anniero98 @wangannie

@thumn thumn requested a review from wangannie April 30, 2020 06:06
Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both cases and everything works well! Thank you so much for handling this.

@wangannie wangannie merged commit 899ca38 into master Apr 30, 2020
@wangannie wangannie deleted the thu/hours-bug branch April 30, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Closed until' is incorrect when a store opens later in the same day
2 participants