Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated How It Works #147

Merged
merged 11 commits into from
May 5, 2020
Merged

Updated How It Works #147

merged 11 commits into from
May 5, 2020

Conversation

kennethlien
Copy link
Contributor

@kennethlien kennethlien commented May 3, 2020

What's new in this PR

Used Ace's new How It Works photos in place of the old one! Added a third tab to make it more convenient for users to resolve #137 .

How to review

See if the styling holds up, and if spacing looks alright. Haven't tested on smaller devices as well, so please double check.

Relevant Links

Online sources

Related PRs

Next steps

Screenshots

image
image
//: # "Add screenshots of expected behavior - GIFs if you're feeling fancy!"

CC: @anniero98 @wangannie

Uploading 80895762...

@kennethlien kennethlien requested review from wangannie and aceschen May 3, 2020 00:50
Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY this looks great! Can you just add a bit of padding under Participating Stores so it's not so close to the bottom?

image

@@ -9,7 +9,7 @@ export default function ParticipatingStores({ participating, guest }) {
const navigation = useNavigation();
return (
<ColumnContainer
style={guest ? { marginLeft: 16, marginBottom: 24 } : { marginTop: 28 }}>
style={guest ? { marginLeft: 16, marginBottom: 40 } : { marginTop: 28 }}>
<Overline style={{}}>Participating Stores</Overline>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These empty style brackets??

Copy link
Contributor

@aceschen aceschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • How It Works tab looks great!! :D (I was only able to view when logged in)
  • [EDIT: FIXED!] Participating Stores header not left aligned with Reward Progress and Available Rewards headers and needs a bit more vertical padding (img below)

image

@aceschen aceschen self-requested a review May 5, 2020 16:34
}}
/>
</View>
<ParticipatingStores participating={participating} guest />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait this should not include guest

Copy link
Member

@wangannie wangannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@wangannie wangannie merged commit d5353b7 into master May 5, 2020
@wangannie wangannie deleted the kenneth/howitworks branch May 5, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dedicated tab for How It Works
3 participants