-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android styling and products bug fixes #78
Conversation
…chen into AnnieW/android_styling_fixes
@@ -252,7 +252,7 @@ export default class MapScreen extends React.Component { | |||
enabledInnerScrolling={false} | |||
enabledBottomClamp | |||
overdragResistanceFactor={1} | |||
enabledGestureInteraction | |||
enabledContentTapInteraction={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't understand why this has to be false for the buttons to be clickable. It seems super counterintuitive but it finally worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Android:
- Font inconsistencies are fixed (all Poppins)
- Rewards banner visible
- Map is still sometimes jittery when viewing a lot of location markers, snaps back to true north if rotated
- Product list and detail buttons work, bottom line of list gets cut off
- Horizontal scroll in products works
- Search bar text in subhead, should be body
- Drop shadows for hamburger menu and search bar work on map screen, bottom drawer does not
What's new in this PR
FYI: Some gesture-related components must be imported from
react-native-gesture-handler
instead ofreact-native
for them to work on Android. This fixedFlatList
scrolling issues, but in some cases like forTouchableOpacity
,react-native-gesture-handler
worked for Android but wouldn't work for iOS.Relevant Links
Online sources
Styling:
Basically, I realized you can't use a custom font-weight or Android will get confused and resort to the system default. Also, regular shadows don't work on Android and you have to use elevation values.
react-navigation/react-navigation#2822
Touch gesture bugs:
osdnk/react-native-reanimated-bottom-sheet#16
osdnk/react-native-reanimated-bottom-sheet#19
osdnk/react-native-reanimated-bottom-sheet#20
Related PRs
How to review
To test without running the repo locally: https://exp.host/@wangannie/healthycorners
Next steps
Tests Performed, Edge Cases
Screenshots
Fixed fonts in drawer:
Added shadows and fixed hidden Rewards button issue

Products bug fix
https://www.loom.com/share/804797c171c04695b77ccf99a61bb546