Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase integration + Analytics #88

Merged
merged 11 commits into from
Apr 18, 2020
Merged

Firebase integration + Analytics #88

merged 11 commits into from
Apr 18, 2020

Conversation

wangannie
Copy link
Member

@wangannie wangannie commented Apr 13, 2020 •
edited
Loading

What's new in this PR

  • Integrated Firebase setup for Firebase Analytics
  • Added a few basic analytics events tracking just for testing:
    • When resources external links are opened
    • Logs user IDs
    • Navigation screen changes

Relevant Links

Online sources

Set up navigation screen tracking here: https://reactnavigation.org/docs/screen-tracking/
More about firebase analytics: https://docs.expo.io/versions/latest/sdk/firebase-analytics/

Related PRs

How to review

  • See if events log in the Firebase Console

Next steps

  • Add more comprehensive analytics events
  • Integrate Firebase phone auth

Tests Performed, Edge Cases

Screenshots

image

CC: @anniero98

@wangannie wangannie requested review from lvlcfm and kennethlien April 13, 2020 02:35
lvlcfm
lvlcfm requested changes Apr 18, 2020
View reviewed changes
Copy link
Member

@lvlcfm lvlcfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Logging works as expected on the dashboard. Small suggestion and this should be good to go!

screens/auth/LogInScreen.js Outdated Show resolved Hide resolved
screens/auth/SignUpScreen.js Outdated Show resolved Hide resolved
@wangannie wangannie requested a review from lvlcfm April 18, 2020 08:09
lvlcfm
lvlcfm approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@lvlcfm lvlcfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀great job!!! good call on sync-ing the sentry and firebase fields

@wangannie wangannie merged commit 0fd2f50 into master Apr 18, 2020
@wangannie wangannie deleted the AnnieW/firebase branch April 18, 2020 08:46
@wangannie wangannie restored the AnnieW/firebase branch April 18, 2020 08:50
@annieyro annieyro deleted the AnnieW/firebase branch April 18, 2020 18:06
@wangannie wangannie mentioned this pull request Apr 25, 2020
Merged
@wangannie wangannie mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvlcfm lvlcfm lvlcfm approved these changes

@kennethlien kennethlien Awaiting requested review from kennethlien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangannie @lvlcfm