Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc compatibility #212

Merged
merged 6 commits into from Jan 27, 2019
Merged

msvc compatibility #212

merged 6 commits into from Jan 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2019

I've made some changes to allow it to compile in visual studio. I'm currently using it for lmms so not everything has been ported. I've split up the issues in several commits so it's easier to pick and choose if necessary.

justnope added 5 commits January 11, 2019 13:12
*moved VLAs to _alloca when compiled in msvc
*fixed_point: use unsigned iso unsigned long long
*audio_module: replaced zero sized arrays with minimal size of 1
*modules_limit: replaced stackalloc zero sized array with overall_buffer_size
*removed linux specific headers
*added msvc bitscan intrinsic
*win 32 dir implementation
@tresf
Copy link

tresf commented Jan 25, 2019

Downstream temporary fork branch created ladspa-msvc while we wait for merge. When merge is complete, downstream will need to:

Documenting here because downstream (LMMS) is adding MSVC support for all bundled plugins and upstream merging this PR is the trigger for downstream work. I hope that's OK. 🍻

@boomshop boomshop merged commit 0966939 into calf-studio-gear:master Jan 27, 2019
@boomshop
Copy link
Member

Thanks!

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jul 1, 2023

Been searching on my own online to try compile lmms with ladspa on msvc and i just found this. Since it's been merged, how about restarting the efforts.

@tresf
Copy link

tresf commented Jul 1, 2023

Been searching on my own online to try compile lmms with ladspa on msvc and i just found this. Since it's been merged, how about restarting the efforts.

Probably better question for LMMS project? LMMS operates on a fork called LMMS/veal, which still supports LADSPAv1. Since LMMS is close to adding LV2 support, it may make more sense to spend time using upstream, but we'd need a volunteer to spearhead this effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants