Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hinting compatibility for 3.8 #311

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

coordt
Copy link
Member

@coordt coordt commented Mar 5, 2025

No description provided.

Replaced `list` with `List` for type hints to ensure compatibility with earlier Python versions.
Copy link

github-actions bot commented Mar 5, 2025

Version hint: patch
Current version: 1.0.0
New version (when merged): 1.0.1

Comment ID: Display the version hint-auto-generated

Copy link

github-actions bot commented Mar 5, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-05 00:44 UTC

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (26e2b83) to head (9c2bb03).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files          29       29           
  Lines        1948     1948           
  Branches      204      204           
=======================================
  Hits         1831     1831           
  Misses         89       89           
  Partials       28       28           
Flag Coverage Δ
python-3.10 93.99% <100.00%> (ø)
python-3.11 93.99% <100.00%> (ø)
python-3.12 93.99% <100.00%> (ø)
python-3.13 93.99% <100.00%> (ø)
python-3.8 93.99% <100.00%> (ø)
python-3.9 93.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 23a7ccb into master Mar 5, 2025
18 of 19 checks passed
@coordt coordt deleted the 310-version-100-fails-on-python-38 branch March 5, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.0.0 fails on Python 3.8 with: TypeError: 'type' object is not subscriptable
1 participant