-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run android starter #627
Comments
Hey, looks like you haven't listed all the selected options. Could you also provide the example app option (vanilla or test app) and the languages you've picked? |
@atlj I've added these to the issue description - I picked Kotlin + Obj C, and am using the test app as the example. |
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> It fixes #627, as we were having the same issue in our react native project. When opting in Turbo Native Modules or Fabric Views, `cmakeListPath` in generated `react-native.config.js` was not consistent with the hierarchy generated by CodeGen. This fix corrects the path as stated by document. If my fix isn't correct, feel free to correct me. Thank you. ### Test plan <!-- List the steps with which we can test this change. Provide screenshots if this changes anything visual. --> - Select 'Turbo module - requires new arch (experimental)' to create Turbo native module and include it into the project - Build for android with `npx react-native run-android` to validate the fix was correct. --------- Co-authored-by: withSang <[email protected]> Co-authored-by: Burak Güner <[email protected]>
Hi @atlj, This issue exists in RN 0.75 (NEW arch), installed with package that created with turbo modules. |
Hey @anbumagan could you create a new issue and reference this? There are some information in the issue template that we would need to see before being able to help |
Description
Yields the following error
I think it might be something to do with this file - note the space in the directory path passed to "add_subdirectory":
/Users/christopherpitt/Development/luna/RTNMute3/example/android/app/build/generated/autolinking/src/main/jni/Android-autolinking.cmake
Packages
Selected options
❯ Turbo module - requires new arch (experimental)
Link to repro
https://github.com/72days/TestNewFabricModule
Environment
System:
OS: macOS 14.5
CPU: (12) arm64 Apple M2 Pro
Memory: 144.70 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.18.2
path: ~/.nvm/versions/node/v18.18.2/bin/node
Yarn:
version: 3.6.1
path: ~/.nvm/versions/node/v18.18.2/bin/yarn
npm:
version: 9.8.1
path: ~/.nvm/versions/node/v18.18.2/bin/npm
Watchman: Not Found
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK:
API Levels:
- "30"
- "31"
- "33"
- "34"
Build Tools:
- 30.0.3
- 33.0.0
- 33.0.1
- 34.0.0
- 35.0.0
System Images:
- android-34 | Google APIs ARM 64 v8a
- android-35 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2024.1 AI-241.18034.62.2411.12071903
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.12
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.75.2
wanted: 0.75.2
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: false
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: false
The text was updated successfully, but these errors were encountered: