Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install for versions 7 and higher. #125

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Nov 4, 2023

Summary

  1. this library is never used react
  2. npm 7 and above will block installations if an upstream dependency conflict is present that cannot be automatically resolved.

fix:

Test plan

npm -v # 7 or above
npx react-native init tmpRN71 --version 0.71.x --npm
cd tmpRN71
npm install /path/to/image-editor

@retyui retyui changed the title Remove react as peerDependencies Fix npm install for versions 7 and higher. Nov 4, 2023
@thymikee thymikee merged commit e2772d7 into callstack:master Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants