fix: Cropping an image while considering ExifInterface.TAG_ORIENTATION on Android #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retyui
changed the title
|
an issue with RN-vision-camera: UPD: known issue, not a blocker: mrousavy/react-native-vision-camera#2515 
|
mateusz1913
reviewed
Feb 7, 2024
android/src/main/java/com/reactnativecommunity/imageeditor/ImageEditorModuleImpl.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/imageeditor/ImageEditorModuleImpl.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativecommunity/imageeditor/ImageEditorModuleImpl.kt
Show resolved
Hide resolved
retyui
force-pushed
the
fix/retyui/img-orientation
branch
from
66c5bc1 to
030d873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging this PR users will be able to crop images with different exif orientation
Test plan
Orientation (0, 90, 180, 270):
Screen_Recording_20240205_211357_Rn73.mp4
Screen_Recording_20240205_211012_Gallery.mp4