Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Use the default resizeMode: cover value across all platforms #139

Merged

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Feb 19, 2024

Summary

Part of 4.x release: Align a default value of resizeMode across all platforms

Test plan

...

@retyui retyui requested a review from mateusz1913 February 19, 2024 18:05
@retyui retyui mentioned this pull request Feb 19, 2024
8 tasks
ios/RNCImageEditor.mm Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
@retyui retyui force-pushed the fix/retyui/resizeMode-logic branch from fffa207 to 3a93a25 Compare February 20, 2024 18:01
@retyui retyui force-pushed the feature/retyui/resizeMode-default-value branch from 1d577c9 to d74d969 Compare February 20, 2024 18:09
@retyui retyui requested a review from mateusz1913 February 20, 2024 18:09
Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@retyui retyui merged commit 01bed3d into fix/retyui/resizeMode-logic Feb 22, 2024
@retyui retyui deleted the feature/retyui/resizeMode-default-value branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants