Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: [web/android/ios] Upon success, return more image information #140

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

retyui
Copy link
Collaborator

@retyui retyui commented Feb 19, 2024

Summary

Part of 4.x release: Convert a uri crop result to an object

Test plan

Examples:

// web
{
    "width": 1125,
    "height": 750,
    "name": "ReactNative_cropped_image.jpeg",
    "size": 283213,
    "path": "blob:http://localhost:8082/43ff7a16-c464-4130-a3d2-95286bae46b1",
    "uri": "data:image/jpeg;base64,/9j/4A|"
}
// android
{
  "height": 600,
  "size": 31520,
  "name": "ReactNative_cropped_image_5129169684629022727.jpg",
  "width": 800,
  "uri": "file:///data/user/0/com.rn73/cache/ReactNative_cropped_image_5129169684629022727.jpg",
  "path": "/data/user/0/com.rn73/cache/ReactNative_cropped_image_5129169684629022727.jpg"
}
// ios
{
  "path": "/Users/davydnarbutovich/Library/Developer/CoreSimulator/Devices/0CA37DFB-8AF0-4714-A849-82E2EE03634F/data/Containers/Data/Application/AD103DB7-10DA-4D4E-A7DD-BDCE371A961D/Library/Caches/ReactNative_cropped_image_/431C35F1-29EC-4972-84C5-01574DDCFDEE.png",
  "size": 280504,
  "height": 800,
  "name": "431C35F1-29EC-4972-84C5-01574DDCFDEE.png",
  "uri": "file:///Users/davydnarbutovich/Library/Developer/CoreSimulator/Devices/0CA37DFB-8AF0-4714-A849-82E2EE03634F/data/Containers/Data/Application/AD103DB7-10DA-4D4E-A7DD-BDCE371A961D/Library/Caches/ReactNative_cropped_image_/431C35F1-29EC-4972-84C5-01574DDCFDEE.png",
  "width": 600
}

@retyui retyui requested a review from mateusz1913 February 19, 2024 20:09
@retyui retyui mentioned this pull request Feb 19, 2024
8 tasks
@retyui retyui force-pushed the feature/retyui/change-return-type branch from 040376d to 649ece5 Compare February 20, 2024 10:44
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@retyui retyui force-pushed the feature/retyui/change-return-type branch from 649ece5 to 53f1763 Compare February 20, 2024 18:00
@retyui retyui requested a review from mateusz1913 February 20, 2024 18:00
Copy link
Member

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@retyui retyui merged commit 8ee9eb2 into master Feb 22, 2024
6 checks passed
@retyui retyui deleted the feature/retyui/change-return-type branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants