Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove negative "files" entry which confused Yarn #1453

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Aug 14, 2023

Summary

Seems like negative files entries confuse Yarn, so that it bundles all folders (e.g. website, examples, etc in the NPM package).

https://packagephobia.com/result?p=@testing-library/[email protected]

Fixes #1452

See Yarn issue

Test plan

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a529a2d) 97.56% compared to head (46ff19a) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1453   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          73       73           
  Lines        4312     4312           
  Branches      627      627           
=======================================
  Hits         4207     4207           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski merged commit fa7b76a into main Aug 14, 2023
@mdjastrzebski mdjastrzebski deleted the chore/fix-yarn-publish branch August 14, 2023 12:28
@mdjastrzebski
Copy link
Member Author

This PR has been released in v12.2.2 🪛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest version of npm pkg. RNTL include usless files (4mb)
1 participant