proposed solution to #70 #71
Conversation
When a malformed package is found, an error message is left in the log with the sample of the package that originated it. There is no exception or cause stop the program. Is my first PR, so I'm not sure if I are doing this fine.
proposed solution to calmh#70
|
please add the changes for the test. also in other places we have just reduced the amount of logging printed by the library. i think the logger statements can be omitted. however the message in hex may be added to the error exception (not sure though). |
proposed solution to calmh#70
|
I have deleted the error messages in log and improved a little the error report. If you consider that is better to remove the hex message in error description, I can do. Travis keeps failing and I no understand what means "change the test". Sorry but I have not experience with github and travis. If you tell me how to do it, I can fix it. |
|
great! the test case that is failing is checking whether or not an Exception is thrown on a parse error. you changed the code to not thrown an exception anymore, so the test fails. you should update the test case so that it no longer requires an exception to be thrown, instead checking the returned error object. |
When a malformed package is found, an error message is left in the log with the sample of the package that originated it.
There is no exception or cause stop the program.
Is my first PR, so I'm not sure if I are doing fine.