cast day_of attributes to bigint on Redshift #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cast day_of values to integer
clausherther
approved these changes
May 30, 2021
There was a problem hiding this comment.
Looks good! Thanks for those logs, I think that's the same issue as outlined in #11 but I don't have a good answer on that since I can't test on Redshift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The following fields store double values on Redshift (see: #26 )
day_of_weekday_of_monthday_of_yearFix
Cast to bigint specifically for Redshift
Tests
The tests
iso_week_*,week_start_date,week_end_date,week_of_yearare failing when run on Redshift as shown in the attached logs. Noticed another pull request to fix theiso_weekissue and issue #25; and presume it's the same problem with other tests. However,day_of_*tests are passing. So, it seems like the fix hasn't broken anything.test-output.log