Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-native-autoheight-webview with WebView #13

Merged
merged 5 commits into from
Sep 24, 2018

Conversation

mrded
Copy link
Contributor

@mrded mrded commented Sep 7, 2018

I found a way to adjust the height without using react-native-autoheight-webview module.

Can you please review? It also solves problems with android: #9

@calvinkei
Copy link
Owner

it doesn't work for me.

  1. this.state.height should be initialized in the constructor to prevent undefined height error
  2. if i run it with the demo project, WebView cannot be shown as width is 0
  3. even if i set width to screen width, height of the webview is still not auto adjusted

can you provide a working example code?

@mrded
Copy link
Contributor Author

mrded commented Sep 10, 2018

The problem is also related to this issue: facebook/react-native#11594

Let me try to fix it, I'll get back to you.

@mrded
Copy link
Contributor Author

mrded commented Sep 11, 2018

@calvinkei Please have a look new version.

this.state.height is set to 1 by default. Which also solved the problem with Hiding content until typesetting is complete#12

@calvinkei calvinkei merged commit ee4d439 into calvinkei:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants