Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Developing Verifiers #1563
base: master
Are you sure you want to change the base?
feat: Developing Verifiers #1563
Changes from all commits
05c6ee4
7b6ebfa
8d3cae0
e5f7a64
605b4ca
4ce3c56
cd456d4
58090c5
5eb9a6f
a2f23c9
0efbda8
abc44b9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add batch process support and add timeout setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wendong-Fan for adding batch processing, I would need to add a
run_batch
method to theBaseInterpreter
class. Should I go ahead and make the changes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also leave the batch process logic within
CodeVerifier
, the batch processing logic is more related to verifier rather than code execution, WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using it in the
CodeVerifier
would mean usingThreadPoolExecutor
while in interpreter it would be based onProcessPoolExecutor
.I think we will be okay moving with ThreadPool for now. Let me know your thoughts on this.