forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github/codeql-action from 2.1.11 to 2.1.21 #1
Closed
dependabot
wants to merge
1
commit into
master
from
dependabot/github_actions/github/codeql-action-2.1.21
Closed
Bump github/codeql-action from 2.1.11 to 2.1.21 #1
dependabot
wants to merge
1
commit into
master
from
dependabot/github_actions/github/codeql-action-2.1.21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.11 to 2.1.21. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@a3a6c12...c7f292e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Dependabot tried to add
|
The following labels could not be found: |
Superseded by #5. |
camsim99
pushed a commit
that referenced
this pull request
Jun 6, 2023
flutter#126548) Cherry-pick flutter#124349 onto stable (3.10). CP request at flutter#126549 Co-authored-by: Jenn Magder <[email protected]>
camsim99
pushed a commit
that referenced
this pull request
Jun 8, 2023
…extMenuBuilder (flutter#128114) Close flutter#128113 Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app! Without the fix, the test fails as expected: <details> ``` (base) â�� flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default' 00:06 +0: context menu contextMenuBuilder changes from default to null â��â��â�¡ EXCEPTION CAUGHT BY WIDGETS LIBRARY â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� The following _TypeError was thrown building _OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state: _OverlayEntryWidgetState#7666a): Null check operator used on a null value When the exception was thrown, this was the stack: #0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43) #1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36) #2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54) #3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36) #4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27) #5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15) #6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32) #11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17) #12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16) flutter#320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5) flutter#321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7) flutter#322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19) flutter#324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19) flutter#325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5) flutter#326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15) flutter#327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9) flutter#328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9) flutter#331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) flutter#332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27) flutter#333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20) flutter#334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14) flutter#337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) flutter#338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27) flutter#339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20) <asynchronous suspension> <asynchronous suspension> (elided 5 frames from dart:async and package:stack_trace) â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� 00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E] Test failed. See exception logs above. The test description was: contextMenuBuilder changes from default to null To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null' 00:06 +0 -1: Some tests failed. (base) â�� flutter git:(feat/text-field-npe) ``` </details>
camsim99
pushed a commit
that referenced
this pull request
Aug 9, 2023
This is a follow up to the following pull requests: - flutter#124514 I was finally able to reproduce this bug and found out why it was happening. Consider this code: ```dart GestureDetector( behavior: HitTestBehavior.translucent, // Note: Make sure onTap is not null to ensure events // are captured by `GestureDetector` onTap: () {}, child: _shouldShowSlider ? Slider(value: _value, onChanged: _handleSlide) : const SizedBox.shrink(). ) ``` Runtime exception happens when: 1. User taps and holds the Slider (drag callback captured by `GestureDetector`) 2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector` 3. Users moves finger as if Slider were still there 4. Drag callback is invoked, `_SliderState.showValueIndicator` is called 5. Exception - Slider is already disposed This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change. The error stack trace is: ``` The following assertion was thrown while handling a gesture: This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active. When the exception was thrown, this was the stack: #0 State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9) #1 State.context (package:flutter/src/widgets/framework.dart:956:6) #2 _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18) #3 _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12) #4 _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5) #5 DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53) #6 GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24) #7 DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7) #8 DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5) #9 DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7) #10 _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14) #11 GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12) #12 GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9) #13 GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12) #14 _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15) #15 _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15) #16 OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13) #17 DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13) #18 PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12) #19 PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9) #20 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) #21 PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18) #22 PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7) #23 GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19) #24 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22) #25 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11) #26 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7) #27 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5) #28 GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7) #29 GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9) #30 _invoke1 (dart:ui/hooks.dart:186:13) #31 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7) #32 _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31) Handler: "onStart" Recognizer: HorizontalDragGestureRecognizer#a5df2 ``` *List which issues are fixed by this PR. You must list at least one issue.* Internal bug: b/273666179, b/192329942 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
camsim99
pushed a commit
that referenced
this pull request
Oct 10, 2023
camsim99
pushed a commit
that referenced
this pull request
Nov 1, 2023
flutter#137242) This reverts commit d36a843 (flutter#136809) This fails even tho golden files were approved and `golden test` pending was cleared and green and `autosubmit` successfully merged the PR. ```console 02:42 +4618 ~5: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following SkiaException was thrown while running async test code: Skia Gold received an unapproved image in post-submit testing. Golden file images in flutter/flutter are triaged in pre-submit during code review for the given PR. Visit https://flutter-gold.skia.org/ to view and approve the image(s), or revert the associated change. For more information, visit the wiki: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter Debug information for Gold -------------------------------- stdout: Given image with hash 37275e74c51f98d7abd7f301c5c94ac1 for test material.outlined_button.ink_sparkle.default Expectation for test: 531f5fa74908d2e6db2b8fd86a6b8662 (positive) Expectation for test: 683e368ff51d947a3d63c2a5f4568cf6 (positive) Expectation for test: 749241ff0fa21595b2c6cb551fd40b68 (positive) Expectation for test: aaf9ac1328614d6c9f4540308bc86f62 (positive) Expectation for test: b31a50440c7dd31b10cacd9e7b5c6b86 (positive) Expectation for test: c0a7c8c625b69ddc695a770f28abd403 (positive) Expectation for test: f1f66ce931c2ef33ebcb699a637025a6 (positive) Expectation for test: 2d32e34efc1d7ca4cd12965402fb76ff (positive) Untriaged or negative image: https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.outlined_button.ink_sparkle.default%26source_type%3Dflutter&digest=37275e74c51f98d7abd7f301c5c94ac1 stderr: Test: material.outlined_button.ink_sparkle.default FAIL result-state.json: No result file found. When the exception was thrown, this was the stack: #0 SkiaGoldClient.imgtestAdd (package:flutter_goldens_client/skia_client.dart:243:7) <asynchronous suspension> #1 MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32) <asynchronous suspension> <asynchronous suspension> (elided one frame from dart:async) The exception was caught asynchronously. ════════════════════════════════════════════════════════════════════════════════════════════════════ 02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works 02:42 +4618 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/outlined_button_test.dart: Material3 - OutlinedButton, OutlinedButton.icon defaults [E] Test failed. See exception logs above. The test description was: Material3 - OutlinedButton, OutlinedButton.icon defaults 02:42 +4619 ~5 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_anchor_test.dart: Menu functions keyboard directional traversal works ``` ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
camsim99
pushed a commit
that referenced
this pull request
Mar 15, 2024
A test was failing silently because of this (see flutter#144353 and fixed in flutter#144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows: ``` 00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following assertion was thrown running a test (but after the test had completed): setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not mounted) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9) #1 State.setState (package:flutter/src/widgets/framework.dart:1202:6) #2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5) <asynchronous suspension> ════════════════════════════════════════════════════════════════════════════════════════════════════ 00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart 00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E] Test failed. See exception logs above. The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart This test failed after it had already completed. Make sure to use a matching library which informs the test runner of pending async work. ```
camsim99
pushed a commit
that referenced
this pull request
Mar 15, 2024
…r#144706)" (flutter#144970) Reverts: flutter#144706 Initiated by: gspencergoog Reason for reverting: This has broken the tree because some tests are still failing post completion. This particular one looks like it might have to do with a gold image not existing. Original PR Author: goderbauer Reviewed By: {Piinks} This change reverts the following previous change: A test was failing silently because of this (see flutter#144353 and fixed in flutter#144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows: ``` 00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following assertion was thrown running a test (but after the test had completed): setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not mounted) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9) #1 State.setState (package:flutter/src/widgets/framework.dart:1202:6) #2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5) <asynchronous suspension> ════════════════════════════════════════════════════════════════════════════════════════════════════ 00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart 00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E] Test failed. See exception logs above. The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart This test failed after it had already completed. Make sure to use a matching library which informs the test runner of pending async work. ```
camsim99
pushed a commit
that referenced
this pull request
Jul 11, 2024
New analyze error in an unrelated PR ``` ╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════ ║ /b/s/w/ir/x/w/flutter/CODEOWNERS:13: trailing U+0020 space character ╚═══════════════════════════════════════════════════════════════════════════════ ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8744032390138579057/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout On this commit flutter@2537b49
camsim99
pushed a commit
that referenced
this pull request
Sep 5, 2024
When attempting to release the Flutter 3.24.1 hotfix, Flutter framework post submits failed due to the following error: ``` ���ERROR #1��������������������������������������������������������������������� � UNEXPECTED ERROR! � Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter � #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:150:12) � <asynchronous suspension> � #1 verifyCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:28:3) � <asynchronous suspension> � #2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:601:5) � <asynchronous suspension> � #3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:125:5) � <asynchronous suspension> � � The test.dart script should be corrected to catch this error and call foundError(). � Some tests are likely to have been skipped. �������������������������������������������������������������������������������� ``` I've updated the tests to include the listed artifact. ### Open questions 1. Is it possible that the test failed only on the first binary? 2. Do we expect a need to add the remainder of the [entitlement changes](flutter/engine@c9b9d57)? 3. I am under the assumption that the bots pull from master and are not branch specific, is this a correct assumption? CC @christopherfujino @cbracken
camsim99
pushed a commit
that referenced
this pull request
Sep 12, 2024
…lutter#154715) Fixes: flutter#154580 Previous PR: flutter#154677 More info: flutter#154580 (comment) The errors described in the original issue [are still occurring](flutter#154580 (comment)) after flutter#154677. Before this change, the repro [broken_demo](https://github.com/rajveermalviya/broken_demo) mentioned in the original issue logs: ```shell-session $ flutter run --release Launching lib/main.dart on sdk gphone64 arm64 in release mode... Running Gradle task 'assembleRelease'... 14.5s â�� Built build/app/outputs/flutter-apk/app-release.apk (7.4MB) Installing build/app/outputs/flutter-apk/app-release.apk... 739ms Flutter run key commands. h List all available interactive commands. c Clear the screen q Quit (terminate the application on the device). W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7). E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null) E/flutter (13284): #0 PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65) E/flutter (13284): <asynchronous suspension> E/flutter (13284): #1 getApplicationSupportDirectory (package:path_provider/path_provider.dart:78) E/flutter (13284): <asynchronous suspension> E/flutter (13284): #2 _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44) E/flutter (13284): <asynchronous suspension> E/flutter (13284): ``` After this change: ```shell-session $ flutter run --release Launching lib/main.dart on sdk gphone64 arm64 in release mode... Running Gradle task 'assembleRelease'... 15.2s â�� Built build/app/outputs/flutter-apk/app-release.apk (7.4MB) Installing build/app/outputs/flutter-apk/app-release.apk... 857ms Flutter run key commands. h List all available interactive commands. c Clear the screen q Quit (terminate the application on the device). I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files' ```
camsim99
pushed a commit
that referenced
this pull request
Sep 12, 2024
flutter#154645) ### Problem Enabling the Swift Package Manager feature caused post-submit tests to fail on Mac x64 hosts: <details> <summary>Example error...</summary> https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20rrect_blur_perf_ios__timeline_summary/575/overview ``` â�¦ ... flutter --verbose assemble ... -dIosArchs=x86_64 ... profile_unpack_ios Target profile_unpack_ios failed: Exception: Binary ... build/ios/Profile-iphoneos/Flutter.framework/Flutter does not contain x86_64. Running lipo -info: Non-fat file: ... build/ios/Profile-iphoneos/Flutter.framework/Flutter is architecture: arm64 #0 UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:351:7) <asynchronous suspension> #1 UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:298:5) <asynchronous suspension> ... ``` </details> ### Reproduction On a mac x64 host: 1. Switch to the latest master channel: `flutter channel master ; flutter upgrade` 1. Disable the Swift Package Manager feature: `flutter config --no-enable-swift-package-manager` 2. Create a Flutter project 2. [Edit the Xcode project manually to add the prepare pre-action](https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#step-2-add-run-prepare-flutter-framework-script-pre-action) 3. Run `flutter run` (`flutter build ios` does not reproduce this issue). ### Background Previously, the Flutter framework was unpacked in the Xcode target's build. Unfortunately, this happens after Swift packages are built; this prevented Swift packages from using the Flutter framework. To fix this, we added an Xcode pre-action that unpacks the Flutter framework _before_ Swift Package Manager builds packages. The Xcode target still runs the Flutter framework unpack step, but this step no-ops if the unpack step has the exact same inputs. ```mermaid flowchart LR A[flutter run -d iphone] --> B(Build Xcode project) B --> C(Xcode 'prepare framework' pre-action) B --> G[Build Swift packages] B --> D(Build 'Runner' target) C --> E[Unpack Flutter framework #1] D --> F[" Unpack Flutter framework #2 (No-ops if inputs are same as #1) "] ``` flutter#150052 added an optimization that made it more likely the second unpack step no-ops by fixing a case where the target architecture input could be different: > When using SwiftPM, we use `flutter assemble` in an Xcode Pre-action to run the `debug_unpack_macos` (or profile/release) target. This target is also later used in a Run Script build phase. Depending on `ARCHS` build setting, the Flutter/FlutterMacOS binary is thinned. In the Run Script build phase, `ARCHS` is filtered to the active arch. However, in the Pre-action it doesn't always filter to the active arch. As a workaround, assume arm64 if the [`NATIVE_ARCH`](https://developer.apple.com/documentation/xcode/build-settings-reference/#NATIVEARCH) is arm, otherwise assume x86_64. This optimization is only applied if [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) is `YES`. > [!IMPORTANT] > [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157)'s name is misleading. It specifies whether the product includes only object code for the native architecture. > > A value of `YES` means the product includes only code for the native architecture ([NATIVE_ARCH](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW59)). > > A value of `NO` means the product includes code for the architectures specified in [ARCHS (Architectures)](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW62). ### Problem `buildXcodeProject` incorrectly always sets `ONLY_ACTIVE_ARCH` to `YES` if the Xcode built is for a single architecture: https://github.com/flutter/flutter/blob/6abef222514e8039bde5c47ab7864abbc4caf7e8/packages/flutter_tools/lib/src/ios/mac.dart#L353-L361 This is incorrect! If the host architecture is `x64` but the target architecture is `arm64`, [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) should be `NO`. This caused the prepare pre-action to incorrectly use x64 as the target architecture for arm64 devices on an x64 host, which in turn caused builds to fail if Swift Package Manager was enabled. ### Solution This change updates `buildXcodeProject` to set `ONLY_ACTIVE_ARCH` correctly. This change also updates the prepare pre-action's to be more conservative in applying the optimization that filters the target architecture. This ensures that the build still works (but without the optimization) if `ONLY_ACTIVE_ARCH` is incorrectly set. Follow-up PR: flutter#154649 This unblocks: flutter#151567 ### DeviceLab test This problem reproduces if you `flutter run` to an iPhone Arm64 device from an x64 mac host with the Swift Package Manager feature enabled. I ran an affected DeviceLab test to verify the fix works as expected: Description | CI test | Result -- | -- | -- SwiftPM enabled without this fix: flutter#154750 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/7/overview) | â�� SwiftPM enabled with this fix: flutter#154749 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/8/overview) | â�
camsim99
pushed a commit
that referenced
this pull request
Feb 13, 2025
The crash indicates that FlutterJNI is returning a nullptr SurfaceControl.Transaction. That likely indicates that we're trying to rasterize a frame before the platform view controller is setup. Potentially a startup race? At any rate, if the PVC is null that means there is no platform views - so it should be safe to create a tx on the fly. Interestingly I cannot repro this locally even on the same device. ``` [2025-02-11 21:50:37.462356] [STDOUT] stdout: [ +173 ms] *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** [2025-02-11 21:50:37.462539] [STDOUT] stdout: [ ] Build fingerprint: 'google/cheetah/cheetah:13/TQ3A.230901.001/10750268:user/release-keys' [2025-02-11 21:50:37.462564] [STDOUT] stdout: [ ] Revision: 'MP1.0' [2025-02-11 21:50:37.463914] [STDOUT] stdout: [ +1 ms] ABI: 'arm64' [2025-02-11 21:50:37.463946] [STDOUT] stdout: [ ] Timestamp: 2025-02-11 21:57:42.183302140-0800 [2025-02-11 21:50:37.463959] [STDOUT] stdout: [ ] Process uptime: 3s [2025-02-11 21:50:37.464054] [STDOUT] stdout: [ ] Cmdline: dev.benchmarks.platform_views_layout [2025-02-11 21:50:37.464174] [STDOUT] stdout: [ ] pid: 15185, tid: 15246, name: 1.raster >>> dev.benchmarks.platform_views_layout <<< [2025-02-11 21:50:37.464354] [STDOUT] stdout: [ ] uid: 10250 [2025-02-11 21:50:37.464398] [STDOUT] stdout: [ ] tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE) [2025-02-11 21:50:37.464440] [STDOUT] stdout: [ ] signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000 [2025-02-11 21:50:37.464602] [STDOUT] stdout: [ ] Cause: null pointer dereference [2025-02-11 21:50:37.464651] [STDOUT] stdout: [ ] x0 b400007b82ff2e70 x1 000000000000002d x2 b400007c3309f370 x3 0000007abbcc6a23 [2025-02-11 21:50:37.464745] [STDOUT] stdout: [ ] x4 0000007a30d286b0 x5 0000007a4f6dd47b x6 0000000000000000 x7 61686b4b11ff3a78 [2025-02-11 21:50:37.464831] [STDOUT] stdout: [ ] x8 0000000000000000 x9 1417c2bd490e1f78 x10 0000000000000010 x11 000000000000009c [2025-02-11 21:50:37.464933] [STDOUT] stdout: [ ] x12 0000000000000adb x13 b400007ba2fe9510 x14 0000000000000e6b x15 b400007ba2fe9510 [2025-02-11 21:50:37.465012] [STDOUT] stdout: [ ] x16 0000000000000001 x17 0000000000000067 x18 0000007a2f996000 x19 b400007b82ff2e70 [2025-02-11 21:50:37.465082] [STDOUT] stdout: [ ] x20 000000000000002d x21 b400007ae3064b60 x22 b400007af30d0fa8 x23 0000000000000001 [2025-02-11 21:50:37.465155] [STDOUT] stdout: [ ] x24 0000007a30d2a000 x25 b400007b73028fb0 x26 0000007a3a22da20 x27 000000003b9bf6c8 [2025-02-11 21:50:37.465235] [STDOUT] stdout: [ ] x28 b400007af30d0fa8 x29 b400007ad3022cd0 [2025-02-11 21:50:37.465318] [STDOUT] stdout: [ ] lr 0000007a3a8c7918 sp 0000007a30d28940 pc 0000000000000000 pst 0000000040001000 [2025-02-11 21:50:37.465401] [STDOUT] stdout: [ ] backtrace: [2025-02-11 21:50:37.465491] [STDOUT] stdout: [ ] #00 pc 0000000000000000 <unknown> [2025-02-11 21:50:37.465596] [STDOUT] stdout: [ ] #1 pc 000000000088b914 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::PlatformViewAndroidJNIImpl::createTransaction()+104) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465688] [STDOUT] stdout: [ ] #2 pc 000000000087f738 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0, std::_fl::allocator<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0>, impeller::android::SurfaceTransaction ()>::operator()()+16) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465785] [STDOUT] stdout: [ ] #3 pc 0000000000bdbf1c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0, std::_fl::allocator<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0>, bool ()>::operator()()+1716) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465874] [STDOUT] stdout: [ ] #4 pc 0000000000b1d180 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::SurfaceFrame::Submit()+148) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465989] [STDOUT] stdout: [ ] #5 pc 0000000000beb2b4 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfacesUnsafe(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+1284) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466400] [STDOUT] stdout: [ ] #6 pc 0000000000beac58 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfaces(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+112) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466444] [STDOUT] stdout: [ ] #7 pc 0000000000bec144 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0, std::_fl::allocator<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0>, void (std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >)>::operator()(std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >&&)+192) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466468] [STDOUT] stdout: [ ] #8 pc 0000000000bebc48 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)+360) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466521] [STDOUT] stdout: [ ] #9 pc 0000000000bf9f7c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0>, std::_fl::allocator<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0> >, void ()>::operator()()+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466543] [STDOUT] stdout: [ ] #10 pc 00000000008a09ec /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopImpl::RunExpiredTasksNow()+728) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466667] [STDOUT] stdout: [ ] #11 pc 00000000008a4600 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466746] [STDOUT] stdout: [ ] #12 pc 0000000000011178 /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+808) (BuildId: 0b4a793fa8045c04066d988c68bac8bb) [2025-02-11 21:50:37.466784] [STDOUT] stdout: [ ] #13 pc 00000000000185e4 /system/lib64/libandroid.so (ALooper_pollOnce+100) (BuildId: 682dab490c18361d5d6527bcdd86cdfa) [2025-02-11 21:50:37.466865] [STDOUT] stdout: [ ] #14 pc 00000000008a470c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::Run()+28) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466903] [STDOUT] stdout: [ ] #15 pc 00000000008a283c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+116) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466943] [STDOUT] stdout: [ ] #16 pc 00000000008a2670 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+8) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.467002] [STDOUT] stdout: [ ] #17 pc 00000000000c226c /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: dc4001c2ef2dfc23467040797a96840c) [2025-02-11 21:50:37.467058] [STDOUT] stdout: [ ] #18 pc 0000000000054a30 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: dc4001c2ef2dfc23467040797a96840c) [2025-02-11 21:50:37.525275] [STDOUT] stdout: [ +57 ms] 00:00 �[32m+0�[0m�[31m -1�[0m: scrolling performance test (setUpAll) �[1m�[31m[E]�[0m�[0m ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github/codeql-action from 2.1.11 to 2.1.21.
Changelog
Sourced from github/codeql-action's changelog.
... (truncated)
Commits
c7f292e
Merge pull request #1212 from github/update-v2.1.21-21bf308700ef1ee
Update changelog for v2.1.2121bf308
Merge pull request #1211 from github/get-default-branch-correctly-schedule5960bff
When running on a schedule, make a better guess about whether we're analyzing...92c650b
Merge pull request #1210 from github/edoardo/record-db-creation-time8b45ef3
Telemetry: Record DB creation timee7d4da3
Merge pull request #1209 from github/henrymercer/fix-go-tracing-tests182342c
Remove unguarded Actions library querye195431
OverrideCODEQL_EXTRACTOR_GO_BUILD_TRACING
withon
when it'strue
3069613
Prevent hangs in Go autobuild tests due to .NET keychain promptsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)