Lint zeebe:TaskSchedule Extension Elements
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
task-schedule
branch
from
9e6cd15 to
eea90f0
Compare
philippfromme
force-pushed
the
task-schedule
branch
from
eea90f0 to
9bf5c8c
Compare
philippfromme
changed the title
zeebe:TaskSchedule Extension Elements
bpmn-io-tasks
bot
added
needs review
smbea
reviewed
Mar 16, 2023
Comment on lines
-11
to
-14
| if (!is(node, 'zeebe:PropertiesHolder')) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you give me a little more context to this here? Why are we removing it?
There was a problem hiding this comment.
We removed this type from the Zeebe model extension (cf. camunda/zeebe-bpmn-moddle#44 and bpmn-io/bpmn-js-properties-panel#861) because any element can have these extension properties. So there's no need for zeebe:PropertiesHolder. Same in Camunda 7.
There was a problem hiding this comment.
Got it, thanks! Was trying to understand the relation to this PR. Will have another look at the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeebe:TaskScheduleextension elements supported by Camunda 8.2 will be validated by the engine. BothdueDateandfollowUpDatewill be validated to be either valid FEEL expressions or valid ISO 8601 DateTime strings.zeebe:TaskScheduleextension elements are only allowed by Camunda 8.2 and newer.Related to camunda/camunda-modeler#3484