Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeebe User Tasks #14

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Zeebe User Tasks #14

merged 4 commits into from
Mar 1, 2021

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Feb 23, 2021

  • Adds support to model user tasks in Zeebe diagrams
  • Adds the Headers and Input/Output tab for user tasks
  • Adds the new user task form definition for user tasks

Related to camunda/camunda-modeler#2104

Bildschirmfoto 2021-02-23 um 08 47 06

Can be tested via

npx @bpmn-io/sr camunda/camunda-bpmn-js#2104-zeebe-user-tasks -c "npm run start:cloud"

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 23, 2021
@pinussilvestrus
Copy link
Contributor Author

@andreasgeier fyi: I think a design review is not necessary for this one, since it includes one input field only. The rest is part of what we discussed yesterday.

@pinussilvestrus
Copy link
Contributor Author

The zeebe-bpmn-moddle changes are released and integrated ✅

Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment to be addressed and also have two remarks below:

  • How about if we validate the form configuration to not accept non-JSON input?
  • A single-line input looks a bit odd for a multi-line JSON. Still, if this is a transition state I am OK with leaving this as it is.

@barmac
Copy link
Contributor

barmac commented Feb 24, 2021

Great job overall :)

@pinussilvestrus
Copy link
Contributor Author

  • How about if we validate the form configuration to not accept non-JSON input?
  • A single-line input looks a bit odd for a multi-line JSON. Still, if this is a transition state I am OK with leaving this as it is.

Good points. I think since we have a transition state here, it's okay to not have validation and the single line input. I'd not put any more effort into the user interaction.

@pinussilvestrus pinussilvestrus changed the title Zeebe User Tasks [WIP] Zeebe User Tasks Feb 24, 2021
@pinussilvestrus pinussilvestrus force-pushed the 2104-zeebe-user-tasks branch 3 times, most recently from dcb8f7f to 34e04b4 Compare February 24, 2021 17:17
* cleanup user task form on removal / replace
* ensure new user task form and definition on copy & paste
@pinussilvestrus
Copy link
Contributor Author

I added another commit (bb96973) which adds an modeling behavior which

  • ensures cleanup on deletion & replace
  • ensures a new user task form with the same content on copy & paste

Ready for review again.

@pinussilvestrus pinussilvestrus changed the title [WIP] Zeebe User Tasks Zeebe User Tasks Feb 25, 2021
@pinussilvestrus
Copy link
Contributor Author

@barmac @MaxTru any chance to get this thing reviewed / merged?

@barmac
Copy link
Contributor

barmac commented Mar 1, 2021

I can look into that today.

@barmac
Copy link
Contributor

barmac commented Mar 1, 2021

One unexpected behaviour:

When I copy a User Task from one diagram to another,
the form definition as well as zeebe:userTaskForm are copied
but the form contents are removed (Form JSON Configuration is empty).

I am OK with merging the PR as it is.

@pinussilvestrus
Copy link
Contributor Author

I think that's pretty much because we can't currently copy the userTaskForm properly, since we don't know where to get the value from, since the rootElement from the copied one isn't available in the newer diagram.

I would also be fine with merging this and wait once someone is reporting it.

@merge-me merge-me bot merged commit 7edee60 into main Mar 1, 2021
@merge-me merge-me bot deleted the 2104-zeebe-user-tasks branch March 1, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants