-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeebe User Tasks #14
Zeebe User Tasks #14
Conversation
@andreasgeier fyi: I think a design review is not necessary for this one, since it includes one input field only. The rest is part of what we discussed yesterday. |
537fe44
to
478262b
Compare
The zeebe-bpmn-moddle changes are released and integrated ✅ |
lib/camunda-cloud/features/properties-provider/parts/implementation/FormDefinition.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment to be addressed and also have two remarks below:
- How about if we validate the form configuration to not accept non-JSON input?
- A single-line input looks a bit odd for a multi-line JSON. Still, if this is a transition state I am OK with leaving this as it is.
Great job overall :) |
Good points. I think since we have a transition state here, it's okay to not have validation and the single line input. I'd not put any more effort into the user interaction. |
dcb8f7f
to
34e04b4
Compare
* cleanup user task form on removal / replace * ensure new user task form and definition on copy & paste
34e04b4
to
bb96973
Compare
I added another commit (bb96973) which adds an modeling behavior which
Ready for review again. |
I can look into that today. |
One unexpected behaviour: When I copy a User Task from one diagram to another, I am OK with merging the PR as it is. |
I think that's pretty much because we can't currently copy the userTaskForm properly, since we don't know where to get the value from, since the I would also be fine with merging this and wait once someone is reporting it. |
Related to camunda/camunda-modeler#2104
Can be tested via
npx @bpmn-io/sr camunda/camunda-bpmn-js#2104-zeebe-user-tasks -c "npm run start:cloud"