Support ad-hoc subprocesses

[saig0]

What should we do?

• zeebe-bpmn-moddle (feat: support zeebe:AdHoc zeebe-bpmn-moddle#69)
  • zeebe:adHoc extension element supported in bpmn:adHocSubProcess only
  • attribute activeElementsCollection of type string
• I can define activeElementsCollection in the properties panel (feat: support ad-hoc subprocesses bpmn-io/bpmn-js-properties-panel#1105)
  • it is FEEL
  • it is optional
• AdHoc subprocess is supported in 8.7 config of camunda/bpmnlint-plugin-camunda-compat (feat: support ad-hoc subprocess bpmnlint-plugin-camunda-compat#187)
• Verify that zeebe:adHoc extension is removed when element type is no longer bpmn:adHocSubProcess (https://github.com/camunda/camunda-bpmn-js-behaviors) (feat: support zeebe:AdHoc camunda-bpmn-js-behaviors#94)
• (may be already done) FEEL expression is validated, and a syntax error is reported
• camunda/linting intergration (feat: support bpmn:AdHocSubProcess linting#128)
  • When FEEL error is clicked, the properties panel entry is focused
  • (may be already done) Verify the errors are human-readable
• User guidance (e.g. via tooltip) and a link to documentation is provided
• Make sure the documentation is released together with modeling support
• Make ad-hoc subprocess more discoverable (Create Ad-Hoc SubProcess via create/replace menu #4801)
• Integrate into camunda-bpmn-js
• Integrate into Desktop Modeler

In C8 BPMN editor

• I can add an ad-hoc subprocess for the execution platform 8.7 and don't see a linting error
  • <= 8.6 indicates incompatibility (as usual)
• I can set the FEEL expression activeElementsCollection on an ad-hoc subprocess

The activeElementsCollection attribute

• Only for ad-hoc processes
• Optional, can be empty
• Must be a FEEL expression
• Description: Return a list of BPMN element ids that should be activated when entering the ad-hoc subprocess.
• XML path: bpmn:adHocSubProcess > bpmn:extensionElements > zeebe:adHoc > activeElementsCollection

XML representation

    <bpmn:adHocSubProcess id="Activity_1kaluzl">
      <bpmn:extensionElements>
        <zeebe:adHoc activeElementsCollection="=activeElements" />
      </bpmn:extensionElements>
      <bpmn:incoming>Flow_1qw4w9y</bpmn:incoming>
      <bpmn:outgoing>Flow_1e61rhe</bpmn:outgoing>
      <bpmn:serviceTask id="Activity_1762pvi" name="A">
        <bpmn:extensionElements>
          <zeebe:taskDefinition type="A" />
        </bpmn:extensionElements>
      </bpmn:serviceTask>
      <bpmn:serviceTask id="Activity_036tbyz" name="B">
        <bpmn:extensionElements>
          <zeebe:taskDefinition type="B" />
        </bpmn:extensionElements>
      </bpmn:serviceTask>
    </bpmn:adHocSubProcess>

BPMN example

Why should we do it?

Child of https://github.com/camunda/product-hub/issues/2546

[barmac]

Thanks for opening the issue! I will put it to the backlog for now but we will keep it in mind for the future planning.
Actually, ready is a better place given the state of the linked epic.

[barmac]

@saig0 Does the zeebe:adHoc extension need to be always present in order to deploy, or can we remove it (not add it) when there is no activeElementsCollection?

[barmac]

To clarify: element templates relevance for the epic

[saig0]

Does the zeebe:adHoc extension need to be always present in order to deploy, or can we remove it (not add it) when there is no activeElementsCollection?

The extension element is optional. It can be removed if the attribute is not set. Or, the attribute can be empty. The runtime supports both. 👍

[jarekdanielak]

@saig0 does the engine support a collapsed ad-hoc subprocess?

[saig0]

does the engine support a collapsed ad-hoc subprocess?

@jarekdanielak yes, it supports collapsed ad-hoc subprocesses too. 👍