[Backport 1.16] fix: Double quotes in string literal are escaped #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case to verify that double quotes are properly escaped in a string literal. (cherry picked from commit f717199)
We should handle escaped double quotes in string literals properly (e.g. `"hello \"FEEL\"!"`). Currently, the quotes are doubled escaped (`"hello \\\"FEEL\\\"!"` but should be `"hello \"FEEL\"!"`). Move the translation of the escape characters to the parsing of the string literal because only string literal can contain these characters. Translating the whole expression would break the parsing. (cherry picked from commit 630ce93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #780 to
1.16.relates to #778